typing

src/ifcopenshell-python/ifcopenshell/api/structural/edit_structural_connection_cs.py

@@ -16,42 +16,33 @@
 # You should have received a copy of the GNU Lesser General Public License
 # along with IfcOpenShell.  If not, see <http://www.gnu.org/licenses/>.
 import ifcopenshell
+from ifcopenshell.util.shape_builder import VectorType, ifc_safe_vector_type
 
 
 def edit_structural_connection_cs(
     file: ifcopenshell.file,
     structural_item: ifcopenshell.entity_instance,
-    axis: tuple[float, float, float] = (0.0, 0.0, 1.0),
-    ref_direction: tuple[float, float, float] = (1.0, 0.0, 0.0),
+    axis: VectorType = (0.0, 0.0, 1.0),
+    ref_direction: VectorType = (1.0, 0.0, 0.0),
 ) -> None:
     """Edits the coordinate system of a structural connection
 
     :param structural_item: The IfcStructuralItem you want to modify.
-    :type structural_item: ifcopenshell.entity_instance
     :param axis: The unit Z axis vector defined as a list of 3 floats.
         Defaults to (0., 0., 1.).
-    :type axis: tuple[float, float, float]
     :param ref_direction: The unit X axis vector defined as a list of 3
         floats. Defaults to (1., 0., 0.).
-    :type ref_direction: tuple[float, float, float]
     :return: None
-    :rtype: None
     """
-    settings = {
-        "structural_item": structural_item,
-        "axis": axis,
-        "ref_direction": ref_direction,
-    }
-
-    if settings["structural_item"].ConditionCoordinateSystem is None:
+    if structural_item.ConditionCoordinateSystem is None:
         point = file.createIfcCartesianPoint((0.0, 0.0, 0.0))
         ccs = file.createIfcAxis2Placement3D(point, None, None)
-        settings["structural_item"].ConditionCoordinateSystem = ccs
+        structural_item.ConditionCoordinateSystem = ccs
 
-    ccs = settings["structural_item"].ConditionCoordinateSystem
+    ccs = structural_item.ConditionCoordinateSystem
     if ccs.Axis and len(file.get_inverse(ccs.Axis)) == 1:
         file.remove(ccs.Axis)
-    ccs.Axis = file.createIfcDirection(settings["axis"])
-    if ccs.RefDirection and len(file.get_inverse(ccs.RefDirection)) == 1:
-        file.remove(ccs.RefDirection)
-    ccs.RefDirection = file.createIfcDirection(settings["ref_direction"])
+    ccs.Axis = file.create_entity("IfcDirection", ifc_safe_vector_type(axis))
+    if (prev_ref_direction := ccs.RefDirection) and len(file.get_inverse(prev_ref_direction)) == 1:
+        file.remove(prev_ref_direction)
+    ccs.RefDirection = file.create_entity("IfcDirection", ifc_safe_vector_type(ref_direction))