Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-21 14:03:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

build: dont provide dependencies to cgal installation

Browse Source 
CGAL never runs `find_package` for `Boost`, `GMP` or `MPFR` during its configuration and never hardcodes their paths to the generated configs. So providing them have no effect. It's also can be confirmed by `build-deps.cmd` on Windows running all this time without the most of these args. Though it was settings `BOOST_ROOT` but it had no effect too.

Probably it's some kind of artifact from CGAL past when it's used to be non-header-only library.
This commit is contained in:
Andrej730
2026-09-08 17:49:34 +05:00
parent 9fd3fd17ab
commit 6ad9386a8d
2 changed files with 1 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
nix/build-all.py
+1 -7
View File
@@ -1567,13 +1567,7 @@ if "cgal" in targets:
build_dependency(
name=cgal_name,
mode="cmake",
build_tool_args=[
f"-DGMP_LIBRARIES={Dependencies.get_install_dir('gmp')}/lib/libgmp.{LIBRARY_EXT}",
f"-DGMP_INCLUDE_DIR={Dependencies.get_install_dir('gmp')}/include",
f"-DMPFR_LIBRARIES={Dependencies.get_install_dir('mpfr')}/lib/libmpfr.{LIBRARY_EXT}",
f"-DMPFR_INCLUDE_DIR={Dependencies.get_install_dir('mpfr')}/include",
f"-DBoost_INCLUDE_DIR={Dependencies.get_install_dir('boost')}",
],
build_tool_args=[],
download_url="https://github.com/CGAL/cgal.git",
download_name="cgal",
download_tool=download_tool_git,