From 6baf3da67a2a692323aba472070beab00a64090b Mon Sep 17 00:00:00 2001
From: Andrej730 <azhilenkov@gmail.com>
Date: Tue, 26 Dec 2023 16:11:53 +0500
Subject: [PATCH] ifctester - added some typing for IDE type hints

---
 src/ifctester/ifctester/facet.py |  5 +++--
 src/ifctester/ifctester/ids.py   | 14 +++++++-------
 2 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/src/ifctester/ifctester/facet.py b/src/ifctester/ifctester/facet.py
index 9fdff87470..2b3f1cd345 100644
--- a/src/ifctester/ifctester/facet.py
+++ b/src/ifctester/ifctester/facet.py
@@ -23,6 +23,7 @@ import ifcopenshell.util.element
 import ifcopenshell.util.classification
 from functools import lru_cache
 from xmlschema.validators import identities
+from typing import List
 
 
 def cast_to_value(from_value, to_value):
@@ -55,8 +56,8 @@ def get_psets(element):
 class Facet:
     def __init__(self, *parameters):
         self.status = None
-        self.failed_entities = []
-        self.failed_reasons = []
+        self.failed_entities: List[Facet] = []
+        self.failed_reasons: List[str] = []
         for i, name in enumerate(self.parameters):
             setattr(self, name.replace("@", ""), parameters[i])
 
diff --git a/src/ifctester/ifctester/ids.py b/src/ifctester/ifctester/ids.py
index 0851e8f9c4..6f4b1d5070 100644
--- a/src/ifctester/ifctester/ids.py
+++ b/src/ifctester/ifctester/ids.py
@@ -21,8 +21,8 @@ import datetime
 from xmlschema import XMLSchema
 from xmlschema import etree_tostring
 from xml.etree import ElementTree as ET
-from .facet import Entity, Attribute, Classification, Property, PartOf, Material, Restriction, get_pset, get_psets
-
+from .facet import Facet, Entity, Attribute, Classification, Property, PartOf, Material, Restriction, get_pset, get_psets
+from typing import List, Set
 
 cwd = os.path.dirname(os.path.realpath(__file__))
 schema = None
@@ -59,7 +59,7 @@ class Ids:
         self.filepath = None
         self.filename = None
 
-        self.specifications = []
+        self.specifications: List[Specification] = []
         self.info = {}
         self.info["title"] = title or "Untitled"
         if copyright:
@@ -141,8 +141,8 @@ class Specification:
         instructions=None,
     ):
         self.name = name or "Unnamed"
-        self.applicability = []
-        self.requirements = []
+        self.applicability: List[Facet] = []
+        self.requirements: List[Facet] = []
         self.minOccurs = minOccurs
         self.maxOccurs = maxOccurs
         self.ifcVersion = ifcVersion
@@ -150,7 +150,7 @@ class Specification:
         self.description = description
         self.instructions = instructions
 
-        self.applicable_entities = []
+        self.applicable_entities: List[Entity] = []
         self.status = None
 
     def asdict(self):
@@ -209,7 +209,7 @@ class Specification:
 
     def reset_status(self):
         self.applicable_entities.clear()
-        self.failed_entities = set()
+        self.failed_entities: Set[Entity] = set()
         for facet in self.requirements:
             facet.status = None
             facet.failed_entities.clear()