From 6c26403b9c7f1d18a0ed0c20917cd5312b29cebd Mon Sep 17 00:00:00 2001 From: Andrej730 Date: Thu, 14 Nov 2024 15:27:51 +0500 Subject: [PATCH] resource.remove_resource - fix bug removing IfcRelAssignsToResource tuple(resource) was resulting in (GlobalId, OwnerHistory, Name, ...) instead of (resource,), so the check never passed and orphaned IfcRelAssignsToResource was never removed. --- .../ifcopenshell/api/resource/remove_resource.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ifcopenshell-python/ifcopenshell/api/resource/remove_resource.py b/src/ifcopenshell-python/ifcopenshell/api/resource/remove_resource.py index 6c061a532d..b9c53c54dc 100644 --- a/src/ifcopenshell-python/ifcopenshell/api/resource/remove_resource.py +++ b/src/ifcopenshell-python/ifcopenshell/api/resource/remove_resource.py @@ -65,7 +65,7 @@ def remove_resource(file: ifcopenshell.file, resource: ifcopenshell.entity_insta ifcopenshell.api.resource.unassign_resource( file, related_object=related_object, relating_resource=settings["resource"] ) - elif inverse.RelatedObjects == tuple(settings["resource"]): + elif inverse.RelatedObjects == (resource,): remove_consider_history(inverse) # Usage was added in IFC4. if usage := getattr(settings["resource"], "Usage", None):