Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-23 19:36:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix error adding typed text annotations #5300

Browse Source 
Apparently it's part of #4832, previously creating a shape for IfcTypeProduct with literals would error, we ignored the error and type product end up being an empty. After 0.8.0 create_shape for literals creates an empty shape (0 verts) and we need to skip it, otherwise there would be an empty mesh representaiton.
This commit is contained in:
Andrej730
2024-09-09 12:11:04 +05:00
parent a3c5c334f1
commit 6da7e18f50
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/bonsai/bonsai/bim/import_ifc.py
+4 -1
View File
@@ -570,7 +570,10 @@ class IfcImporter:
mesh = self.meshes.get(mesh_name) mesh = self.meshes.get(mesh_name)
if mesh is None: if mesh is None:
shape = tool.Loader.create_generic_shape(representation) shape = tool.Loader.create_generic_shape(representation)
if shape: # Skip elements without geometry - e.g. annotations with IfcTextLiterals.
if shape and not shape.verts_buffer:
pass
elif shape:
mesh = self.create_mesh(element, shape) mesh = self.create_mesh(element, shape)
tool.Loader.link_mesh(shape, mesh) tool.Loader.link_mesh(shape, mesh)
self.meshes[mesh_name] = mesh self.meshes[mesh_name] = mesh