Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-08-10 09:48:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

pset.unshare_pset - fix bug where it would leaving an orphaned pset

Browse Source 
It was leaving an orphaned pset if 'products' was a list of all elements pset is assigned to. Then it would create a new pset for each element leaving original pset orphaned.
This commit is contained in:
Andrej730
2024-09-05 18:40:53 +05:00
parent ffb2ea2be3
commit 6ebec7e0e5
3 changed files with 43 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcopenshell-python/ifcopenshell/api/pset/unshare_pset.py
+16
View File
@@ -57,6 +57,22 @@ def unshare_pset(
assert new_pset != pset
assert ifcopenshell.util.element.get_elements_by_pset(new_pset) == {element2}
"""
if not products:
raise Exception("No products provided.")
# If pset has no other elements besides the provided products,
# then we skip the first product, so it won't get additional pset copy
# leaving the original pset orphaned.
pset_elements = ifcopenshell.util.element.get_elements_by_pset(pset)
products_original = products
if set(products) == pset_elements:
products = products[1:]
if not products:
raise Exception(f"Provided product is the only element to which pset is assigned: {products_original[0]}.")
products_occurrences: set[ifcopenshell.entity_instance] = set()
products_types: set[ifcopenshell.entity_instance] = set()
for product in products: