Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-20 06:58:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

Resolved Code Review

Browse Source
This commit is contained in:
Martyna Jakubowska
2023-01-03 16:59:31 +01:00
committed by Dion Moult
parent 56858540b8
commit 70b7f1424f
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcsverchok/__init__.py
+6 -1
View File
@@ -107,6 +107,10 @@ class IFC_Sv_UpdateCurrent(bpy.types.Operator):
node_group: bpy.props.StringProperty(default="") node_group: bpy.props.StringProperty(default="")
force_mode: bpy.props.BoolProperty(default=False) force_mode: bpy.props.BoolProperty(default=False)
# FIXME For now it's fine to center around buildings.
# But for the future it'd be good to also allow other
# infra-related spatial structure elements, such as IfcBridge.
# https://github.com/IfcOpenShell/IfcOpenShell/pull/2576#discussion_r1016261407
def execute(self, context): def execute(self, context):
self.file = SvIfcStore.purge() self.file = SvIfcStore.purge()
node_tree = context.space_data.node_tree node_tree = context.space_data.node_tree
@@ -189,8 +193,9 @@ class IFC_Sv_write_file(bpy.types.Operator):
if not self.file: if not self.file:
raise Exception("No IFC file in SvIfcStore.") raise Exception("No IFC file in SvIfcStore.")
_, ext = splitext(self.filepath) _, ext = splitext(self.filepath)
# FIXME checking for extension not necessary
if not ext: if not ext:
raise Exception("Bad path. Provide a path to a file.") raise Exception("Bad path. Provide a path to a file ending with a file extension.")
else: else:
self.ensure_hirarchy(self.file) self.ensure_hirarchy(self.file)
self.file.write(self.filepath) self.file.write(self.filepath)