Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-08-10 09:48:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

append_asset - ensure to update existing rels appending second asset

Browse Source 
E.g. in #5890 pset was shared by 2 elements and they it worked is
1) it appended first element and it's rel to pset
2) it appended second element and skipped updating it's rel as it was appended before. Now it's going to update it to ensure it encludes second element too.

I believe, issue occurred after 8c28f52 when we stopped duplicating inverses and started to reuse them.
This commit is contained in:
Andrej730
2024-12-20 12:45:39 +05:00
parent 8c6eddfb66
commit 74fe1b4eb9
2 changed files with 38 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcopenshell-python/test/api/project/test_append_asset.py
+18
View File
@@ -433,6 +433,24 @@ class TestAppendAssetIFC2X3(test.bootstrap.IFC2X3):
del shading_colour_info["id"], shading_colour_info["type"]
assert shading_colour_info == shading_attrs["SurfaceColour"]
def test_update_rels_appending_subsequent_assets(self):
library = ifcopenshell.api.project.create_file(version=self.file.schema)
element1 = ifcopenshell.api.root.create_entity(library, ifc_class="IfcWall")
pset = ifcopenshell.api.pset.add_pset(library, product=element1, name="Test")
element2 = ifcopenshell.api.root.create_entity(library, ifc_class="IfcWall")
ifcopenshell.api.pset.assign_pset(library, pset=pset, products=[element2])
reuse_identities = {}
element1_ = ifcopenshell.api.project.append_asset(
self.file, library, element1, reuse_identities=reuse_identities
)
element2_ = ifcopenshell.api.project.append_asset(
self.file, library, element2, reuse_identities=reuse_identities
)
pset_data = ifcopenshell.util.element.get_psets(element1_)
assert "Test" in pset_data
assert ifcopenshell.util.element.get_psets(element2_) == pset_data
class TestAppendAssetIFC4(test.bootstrap.IFC4, TestAppendAssetIFC2X3):
# NOTE: breaks in IFC2X3 since IfcProfileDef doesn't have "HasProperties" inverse in ifc2x3