Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-19 06:39:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Re-sew non-manifold operands; interior loop re-orientations affect edge identity #8140

Browse Source
This commit is contained in:
Thomas Krijnen
2026-06-04 21:37:41 +02:00
parent 4520a72152
commit 77a2284f8a
1 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcgeom/kernels/opencascade/OpenCascadeKernel.cpp
+11
View File
@@ -136,6 +136,17 @@ bool IfcGeom::OpenCascadeKernel::convert_openings(const IfcUtil::IfcBaseEntity*
for (auto entity_part : parts) { for (auto entity_part : parts) {
bool is_manifold = util::is_manifold(entity_part); bool is_manifold = util::is_manifold(entity_part);
if (!is_manifold) {
// force sewing, edge identity might have been mudied by FixAdvFace.FixOrientation.MSG5 to fix interior loop winding order
TopTools_ListOfShape list;
IfcGeom::util::shape_to_face_list(entity_part, list);
IfcGeom::util::create_solid_from_faces(list, entity_part, settings_.get<settings::Precision>().get(), true);
is_manifold = util::is_manifold(entity_part);
if (is_manifold) {
Logger::Warning("Successfully sewed non-manifold first operand");
}
}
if (!is_manifold) { if (!is_manifold) {
if (settings_.get<settings::MakeVolume>().get()) { if (settings_.get<settings::MakeVolume>().get()) {
BOPAlgo_MakerVolume mv; BOPAlgo_MakerVolume mv;