From 7842877ba06acf11212c8a4b9d305c4c933352c7 Mon Sep 17 00:00:00 2001 From: Andrej730 Date: Mon, 3 Apr 2023 19:44:37 +0500 Subject: [PATCH] Fixed ifc validation errors for generated openings #2925 --- src/blenderbim/blenderbim/bim/module/model/opening.py | 4 +++- src/blenderbim/blenderbim/bim/module/model/window.py | 6 ++++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/src/blenderbim/blenderbim/bim/module/model/opening.py b/src/blenderbim/blenderbim/bim/module/model/opening.py index 0d0115177f..0bb4c21abc 100644 --- a/src/blenderbim/blenderbim/bim/module/model/opening.py +++ b/src/blenderbim/blenderbim/bim/module/model/opening.py @@ -232,7 +232,9 @@ class FilledOpeningGenerator: ifcopenshell.util.representation.resolve_representation(profile).Items[0], magnitude=thickness / unit_scale, position=Vector([0.0, -0.1 / unit_scale, 0.0]), - extrusion_vector=Vector([0.0, 1.0, 0.0]), + position_x_axis=Vector((1, 0, 0)), + position_z_axis=Vector((0, -1, 0)), + extrusion_vector=Vector((0, 0, -1)), ) return shape_builder.get_representation(context, [extrusion]) diff --git a/src/blenderbim/blenderbim/bim/module/model/window.py b/src/blenderbim/blenderbim/bim/module/model/window.py index 8dee9b3629..1ee9bc848a 100644 --- a/src/blenderbim/blenderbim/bim/module/model/window.py +++ b/src/blenderbim/blenderbim/bim/module/model/window.py @@ -69,10 +69,12 @@ def update_simple_openings(element, opening_width, opening_height): context = ifcopenshell.util.representation.get_context(ifc_file, "Model", "Body", "MODEL_VIEW") extrusion = shape_builder.extrude( - shape_builder.rectangle(size=Vector([opening_width, 0.0, opening_height])), + shape_builder.rectangle(size=Vector([opening_width, 0.0, opening_height]).xz), magnitude=thickness / unit_scale, position=Vector([0.0, -0.1 / unit_scale, 0.0]), - extrusion_vector=Vector([0.0, 1.0, 0.0]), + position_x_axis=V(1, 0, 0), + position_z_axis=V(0, -1, 0), + extrusion_vector=V(0, 0, -1), ) new_representation = shape_builder.get_representation(context, extrusion)