From 7b296629d6eb03dbf074d79a49b536d95c52dd21 Mon Sep 17 00:00:00 2001 From: Thomas Krijnen Date: Fri, 12 Apr 2024 10:23:27 +0200 Subject: [PATCH] Doing a transpose was most likely misguided --- src/ifcgeom/mapping/IfcCartesianTransformationOperator2D.cpp | 3 ++- src/ifcgeom/mapping/IfcSectionedSolidHorizontal.cpp | 3 +-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/ifcgeom/mapping/IfcCartesianTransformationOperator2D.cpp b/src/ifcgeom/mapping/IfcCartesianTransformationOperator2D.cpp index 496aac2e23..70eedc7988 100644 --- a/src/ifcgeom/mapping/IfcCartesianTransformationOperator2D.cpp +++ b/src/ifcgeom/mapping/IfcCartesianTransformationOperator2D.cpp @@ -55,7 +55,8 @@ taxonomy::ptr mapping::map_impl(const IfcSchema::IfcCartesianTransformationOpera axis3, origin; - m->components().transposeInPlace(); + // @todo why was this here + // m->components().transposeInPlace(); return m; } diff --git a/src/ifcgeom/mapping/IfcSectionedSolidHorizontal.cpp b/src/ifcgeom/mapping/IfcSectionedSolidHorizontal.cpp index fdb1946ff5..5dbee7cff7 100644 --- a/src/ifcgeom/mapping/IfcSectionedSolidHorizontal.cpp +++ b/src/ifcgeom/mapping/IfcSectionedSolidHorizontal.cpp @@ -253,8 +253,7 @@ taxonomy::ptr mapping::map_impl(const IfcSchema::IfcSectionedSolidHorizontal* in // @todo should this not be initialized by default? matrix4 already has a 'lazy identity' mechanism. loft->children.back()->matrix = taxonomy::make(); } - // @todo why do we do a transpose here, that doesn't seem right. - auto m = (m4b * loft->children.back()->matrix->ccomponents().transpose()).eval(); + auto m = (m4b * loft->children.back()->matrix->ccomponents()).eval(); loft->children.back()->matrix->components() = m; } }