From 7b6e82a9cc4badcc9a078a502c8ab31be44dc865 Mon Sep 17 00:00:00 2001 From: Dion Moult Date: Fri, 20 Mar 2026 23:09:15 +1100 Subject: [PATCH] Fix stair calculated params test to set custom_tread_lock=False Tests using custom first/last tread runs were not setting custom_tread_lock=False, so the custom values were silently ignored since 8f7cf76d9 introduced the lock gate in the calculation. Co-Authored-By: Claude Opus 4.6 --- src/bonsai/test/tool/test_model.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/bonsai/test/tool/test_model.py b/src/bonsai/test/tool/test_model.py index 756268cbee..30782b8a15 100644 --- a/src/bonsai/test/tool/test_model.py +++ b/src/bonsai/test/tool/test_model.py @@ -176,6 +176,7 @@ class TestStairCalculatedParams(NewFile): pset_data = pset_data_base.copy() calculated_data = calculated_data_base.copy() pset_data["custom_first_last_tread_run"] = (0.1, 0.4) + pset_data["custom_tread_lock"] = False calculated_data["Length"] += -0.2 + 0.1 self.compare_data(pset_data, calculated_data) @@ -183,6 +184,7 @@ class TestStairCalculatedParams(NewFile): pset_data = pset_data_base.copy() calculated_data = calculated_data_base.copy() pset_data["custom_first_last_tread_run"] = (0.0, None) + pset_data["custom_tread_lock"] = False calculated_data["Length"] = 0.9 # Only 3 treads at 0.3 each self.compare_data(pset_data, calculated_data) @@ -190,6 +192,7 @@ class TestStairCalculatedParams(NewFile): pset_data = pset_data_base.copy() calculated_data = calculated_data_base.copy() pset_data["custom_first_last_tread_run"] = (None, 0.0) + pset_data["custom_tread_lock"] = False calculated_data["Length"] = 0.9 # Only 3 treads at 0.3 each self.compare_data(pset_data, calculated_data) @@ -197,6 +200,7 @@ class TestStairCalculatedParams(NewFile): pset_data = pset_data_base.copy() calculated_data = calculated_data_base.copy() pset_data["custom_first_last_tread_run"] = (0.0, 0.0) + pset_data["custom_tread_lock"] = False calculated_data["Length"] = 0.6 # Only 2 middle treads at 0.3 each self.compare_data(pset_data, calculated_data)