mirror of
https://github.com/IfcOpenShell/IfcOpenShell.git
synced 2026-09-19 22:50:21 +00:00
Misc. typos
Found via `codespell -q 3`
This commit is contained in:
@@ -240,7 +240,7 @@ int main() {
|
|||||||
file.addBuildingProduct(west_wall);
|
file.addBuildingProduct(west_wall);
|
||||||
|
|
||||||
// The west wall is assigned an opening element we created for the south wall, opening elements are
|
// The west wall is assigned an opening element we created for the south wall, opening elements are
|
||||||
// not shared accross building elements, even if they share the same representation. Hence, the east
|
// not shared across building elements, even if they share the same representation. Hence, the east
|
||||||
// wall will not feature this opening.
|
// wall will not feature this opening.
|
||||||
// NB: an Opening Element can only be used to create a single void within a single Element, as per:
|
// NB: an Opening Element can only be used to create a single void within a single Element, as per:
|
||||||
// http://www.buildingsmart-tech.org/ifc/IFC2x3/TC1/html/ifcproductextension/lexical/ifcfeatureelementsubtraction.htm
|
// http://www.buildingsmart-tech.org/ifc/IFC2x3/TC1/html/ifcproductextension/lexical/ifcfeatureelementsubtraction.htm
|
||||||
@@ -412,7 +412,7 @@ int main() {
|
|||||||
// Therefore we will construct the window as a decomposition of beams and a plate, in which
|
// Therefore we will construct the window as a decomposition of beams and a plate, in which
|
||||||
// only the plate will have a transparent material assigned.
|
// only the plate will have a transparent material assigned.
|
||||||
|
|
||||||
// The window frame will consists of four seperate beams.
|
// The window frame will consists of four separate beams.
|
||||||
// AutoCAD Architecture will create an internal window type for the IfcWindow created.
|
// AutoCAD Architecture will create an internal window type for the IfcWindow created.
|
||||||
// Therefore the OverallWidth and OverallHeight of the window attributes will need to
|
// Therefore the OverallWidth and OverallHeight of the window attributes will need to
|
||||||
// match the bounding box of the representation. Furthermore, the window placement needs
|
// match the bounding box of the representation. Furthermore, the window placement needs
|
||||||
@@ -463,10 +463,10 @@ int main() {
|
|||||||
);
|
);
|
||||||
file.addBuildingProduct(window);
|
file.addBuildingProduct(window);
|
||||||
|
|
||||||
// Initalize a list of parts for the window to be composed of
|
// Initialize a list of parts for the window to be composed of
|
||||||
IfcSchema::IfcObjectDefinition::list::ptr window_parts(new IfcTemplatedEntityList<IfcSchema::IfcObjectDefinition>());
|
IfcSchema::IfcObjectDefinition::list::ptr window_parts(new IfcTemplatedEntityList<IfcSchema::IfcObjectDefinition>());
|
||||||
|
|
||||||
// The placements for the beams are not shared accross the different windows because every
|
// The placements for the beams are not shared across the different windows because every
|
||||||
// beam is placed relative to its parent window entity.
|
// beam is placed relative to its parent window entity.
|
||||||
IfcSchema::IfcLocalPlacement::list::ptr frame_placements (new IfcTemplatedEntityList<IfcSchema::IfcLocalPlacement>());
|
IfcSchema::IfcLocalPlacement::list::ptr frame_placements (new IfcTemplatedEntityList<IfcSchema::IfcLocalPlacement>());
|
||||||
frame_placements->push(file.addLocalPlacement(storey_placement, 930,45));
|
frame_placements->push(file.addLocalPlacement(storey_placement, 930,45));
|
||||||
|
|||||||
@@ -257,7 +257,7 @@ int main(int argc, char** argv)
|
|||||||
"Not guaranteed to work properly if used with --weld-vertices.")
|
"Not guaranteed to work properly if used with --weld-vertices.")
|
||||||
("filter-file", po::value<std::string>(&filter_filename),
|
("filter-file", po::value<std::string>(&filter_filename),
|
||||||
"Specifies a filter file that describes the used filtering criteria. Supported formats "
|
"Specifies a filter file that describes the used filtering criteria. Supported formats "
|
||||||
"are '--include=arg GlobalId ...' and 'include arg GlobalId ...'. Spaces and tabs can be used as delimeters."
|
"are '--include=arg GlobalId ...' and 'include arg GlobalId ...'. Spaces and tabs can be used as delimiters."
|
||||||
"Multiple filters of same type with different values can be inserted on their own lines. "
|
"Multiple filters of same type with different values can be inserted on their own lines. "
|
||||||
"See --include, --include+, --exclude, and --exclude+ for more details.");
|
"See --include, --include+, --exclude, and --exclude+ for more details.");
|
||||||
|
|
||||||
|
|||||||
@@ -464,7 +464,7 @@ void XmlSerializer::finalize() {
|
|||||||
|
|
||||||
// Layer assignments. IfcPresentationLayerAssignments don't have GUIDs (only optional Identifier)
|
// Layer assignments. IfcPresentationLayerAssignments don't have GUIDs (only optional Identifier)
|
||||||
// so use names as the IDs and only insert those with unique names. In case of possible duplicate names/IDs
|
// so use names as the IDs and only insert those with unique names. In case of possible duplicate names/IDs
|
||||||
// the first IfcPresentationLayerAssignment occurence takes precedence.
|
// the first IfcPresentationLayerAssignment occurrence takes precedence.
|
||||||
std::set<std::string> layer_names;
|
std::set<std::string> layer_names;
|
||||||
IfcPresentationLayerAssignment::list::ptr layer_assignments = file->entitiesByType<IfcPresentationLayerAssignment>();
|
IfcPresentationLayerAssignment::list::ptr layer_assignments = file->entitiesByType<IfcPresentationLayerAssignment>();
|
||||||
for (IfcPresentationLayerAssignment::list::it it = layer_assignments->begin(); it != layer_assignments->end(); ++it) {
|
for (IfcPresentationLayerAssignment::list::it it = layer_assignments->begin(); it != layer_assignments->end(); ++it) {
|
||||||
|
|||||||
@@ -139,12 +139,12 @@ public:
|
|||||||
// Default: 0.001m / 1mm
|
// Default: 0.001m / 1mm
|
||||||
GV_DEFLECTION_TOLERANCE,
|
GV_DEFLECTION_TOLERANCE,
|
||||||
// Specifies the tolerance of the wire builder, most notably for trimmed curves
|
// Specifies the tolerance of the wire builder, most notably for trimmed curves
|
||||||
// Defailt: 0.0001m / 0.1mm
|
// Default: 0.0001m / 0.1mm
|
||||||
GV_WIRE_CREATION_TOLERANCE,
|
GV_WIRE_CREATION_TOLERANCE,
|
||||||
// Specifies the minimal area of a face to be included in an IfcConnectedFaceset
|
// Specifies the minimal area of a face to be included in an IfcConnectedFaceset
|
||||||
// Read-only
|
// Read-only
|
||||||
GV_MINIMAL_FACE_AREA,
|
GV_MINIMAL_FACE_AREA,
|
||||||
// Specifies the treshold distance under which cartesian points are deemed equal
|
// Specifies the threshold distance under which cartesian points are deemed equal
|
||||||
// Default: 0.00001m / 0.01mm
|
// Default: 0.00001m / 0.01mm
|
||||||
GV_POINT_EQUALITY_TOLERANCE,
|
GV_POINT_EQUALITY_TOLERANCE,
|
||||||
// Specifies maximum number of faces for a shell to be sewed. Sewing shells
|
// Specifies maximum number of faces for a shell to be sewed. Sewing shells
|
||||||
|
|||||||
@@ -675,10 +675,10 @@ bool IfcGeom::Kernel::convert_curve_to_wire(const Handle(Geom_Curve)& curve, Top
|
|||||||
if (e.GetMessageString() && strlen(e.GetMessageString())) {
|
if (e.GetMessageString() && strlen(e.GetMessageString())) {
|
||||||
Logger::Error(e.GetMessageString());
|
Logger::Error(e.GetMessageString());
|
||||||
} else {
|
} else {
|
||||||
Logger::Error("Unknown error convering curve to wire");
|
Logger::Error("Unknown error converting curve to wire");
|
||||||
}
|
}
|
||||||
} catch (...) {
|
} catch (...) {
|
||||||
Logger::Error("Unknown error convering curve to wire");
|
Logger::Error("Unknown error converting curve to wire");
|
||||||
}
|
}
|
||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
@@ -2539,7 +2539,7 @@ bool IfcGeom::Kernel::project(const Handle_Geom_Surface& srf, const TopoDS_Shape
|
|||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
|
|
||||||
// Add a little bit of resulution so that the median is shifted towards the mass
|
// Add a little bit of resolution so that the median is shifted towards the mass
|
||||||
// of the curve. This helps to find the parameter ordering for conic surfaces.
|
// of the curve. This helps to find the parameter ordering for conic surfaces.
|
||||||
for (TopExp_Explorer exp(shp, TopAbs_EDGE); exp.More(); exp.Next(), ++vertex_count) {
|
for (TopExp_Explorer exp(shp, TopAbs_EDGE); exp.More(); exp.Next(), ++vertex_count) {
|
||||||
const TopoDS_Edge& e = TopoDS::Edge(exp.Current());
|
const TopoDS_Edge& e = TopoDS::Edge(exp.Current());
|
||||||
|
|||||||
@@ -349,7 +349,7 @@ namespace IfcGeom {
|
|||||||
// Move to the next IfcRepresentation
|
// Move to the next IfcRepresentation
|
||||||
void _nextShape() {
|
void _nextShape() {
|
||||||
// In order to conserve memory and reduce cache insertion times, the cache is
|
// In order to conserve memory and reduce cache insertion times, the cache is
|
||||||
// cleared after an arbitary number of processed representations. This has been
|
// cleared after an arbitrary number of processed representations. This has been
|
||||||
// benchmarked extensively: https://github.com/IfcOpenShell/IfcOpenShell/pull/47
|
// benchmarked extensively: https://github.com/IfcOpenShell/IfcOpenShell/pull/47
|
||||||
static const int clear_interval = 64;
|
static const int clear_interval = 64;
|
||||||
if (done % clear_interval == clear_interval - 1) {
|
if (done % clear_interval == clear_interval - 1) {
|
||||||
@@ -437,7 +437,7 @@ namespace IfcGeom {
|
|||||||
|
|
||||||
IfcSchema::IfcRepresentation* representation_mapped_to = kernel.representation_mapped_to(representation);
|
IfcSchema::IfcRepresentation* representation_mapped_to = kernel.representation_mapped_to(representation);
|
||||||
if (representation_mapped_to) {
|
if (representation_mapped_to) {
|
||||||
// Check if this represenation has (or will be) processed as part its mapped representation
|
// Check if this representation has (or will be) processed as part its mapped representation
|
||||||
representation_processed_as_mapped_item = ok_mapped_representations->contains(representation_mapped_to) ||
|
representation_processed_as_mapped_item = ok_mapped_representations->contains(representation_mapped_to) ||
|
||||||
reuse_ok_(kernel.products_represented_by(representation_mapped_to));
|
reuse_ok_(kernel.products_represented_by(representation_mapped_to));
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -304,7 +304,7 @@ bool IfcGeom::Kernel::convert(const IfcSchema::IfcCompositeCurve* l, TopoDS_Wire
|
|||||||
use_radians = true;
|
use_radians = true;
|
||||||
} else {
|
} else {
|
||||||
// No heuristic left to prefer the one over the other,
|
// No heuristic left to prefer the one over the other,
|
||||||
// apparently both variants are equally succesful.
|
// apparently both variants are equally successful.
|
||||||
// The curve might be composed of only straight segments.
|
// The curve might be composed of only straight segments.
|
||||||
// Let's go with the wire created using radians as that
|
// Let's go with the wire created using radians as that
|
||||||
// at least is a SI unit.
|
// at least is a SI unit.
|
||||||
|
|||||||
@@ -294,7 +294,7 @@ int IFCImp::DoImport(const TCHAR *name, ImpInterface *impitfc, Interface *itfc,
|
|||||||
tri->mesh.buildNormals();
|
tri->mesh.buildNormals();
|
||||||
// Either use this or undefine the FACESETS_AS_COMPOUND option in IfcGeom.h to have
|
// Either use this or undefine the FACESETS_AS_COMPOUND option in IfcGeom.h to have
|
||||||
// properly oriented normals. Using only the line below will result in a consistent
|
// properly oriented normals. Using only the line below will result in a consistent
|
||||||
// orientation of normals accross shells, but not always oriented towards the
|
// orientation of normals across shells, but not always oriented towards the
|
||||||
// outside.
|
// outside.
|
||||||
// tri->mesh.UnifyNormals(false);
|
// tri->mesh.UnifyNormals(false);
|
||||||
tri->mesh.BuildStripsAndEdges();
|
tri->mesh.BuildStripsAndEdges();
|
||||||
|
|||||||
@@ -196,7 +196,7 @@ class entity_instance(object):
|
|||||||
attr_value = entity_instance.walk(is_instance, get_info_, attr_value)
|
attr_value = entity_instance.walk(is_instance, get_info_, attr_value)
|
||||||
yield self.attribute_name(i), attr_value
|
yield self.attribute_name(i), attr_value
|
||||||
except BaseException:
|
except BaseException:
|
||||||
logging.exception("unhandled exception occured setting attribute name for {}".format(self))
|
logging.exception("unhandled exception occurred setting attribute name for {}".format(self))
|
||||||
|
|
||||||
return return_type(_())
|
return return_type(_())
|
||||||
|
|
||||||
|
|||||||
@@ -80,7 +80,7 @@ namespace IfcWrite {
|
|||||||
boost::dynamic_bitset<>,
|
boost::dynamic_bitset<>,
|
||||||
// An enumeration argument, e.g. .USERDEFINED.
|
// An enumeration argument, e.g. .USERDEFINED.
|
||||||
// To initialize the argument a string representation
|
// To initialize the argument a string representation
|
||||||
// has to be explicitely passed of the enumeration value
|
// has to be explicitly passed of the enumeration value
|
||||||
// which is stored internally as an integer. The argument
|
// which is stored internally as an integer. The argument
|
||||||
// itself does not keep track of what schema enumeration
|
// itself does not keep track of what schema enumeration
|
||||||
// type is represented.
|
// type is represented.
|
||||||
|
|||||||
+1
-1
@@ -145,7 +145,7 @@ echo.
|
|||||||
|
|
||||||
cd "%DEPS_DIR%"
|
cd "%DEPS_DIR%"
|
||||||
|
|
||||||
:: Note all of the depedencies have approriate label so that user can easily skip something if wanted
|
:: Note all of the dependencies have appropriate label so that user can easily skip something if wanted
|
||||||
:: by modifying this file and using goto.
|
:: by modifying this file and using goto.
|
||||||
:Boost
|
:Boost
|
||||||
:: NOTE Boost < 1.64 doesn't work without tricks if the user has only VS 2017 installed and no earlier versions.
|
:: NOTE Boost < 1.64 doesn't work without tricks if the user has only VS 2017 installed and no earlier versions.
|
||||||
|
|||||||
+2
-2
@@ -15,7 +15,7 @@ Usage Instructions
|
|||||||
Building using MSYS is very similar to using the MSVC batch files, but instead the shell scripts
|
Building using MSYS is very similar to using the MSVC batch files, but instead the shell scripts
|
||||||
are used. Note that the MSYS support is currently a bit experimental. It is advised to check out the contents
|
are used. Note that the MSYS support is currently a bit experimental. It is advised to check out the contents
|
||||||
of the shell scripts before using them. Note that contrary to MSVC, with MSYS all of the dependencies are not
|
of the shell scripts before using them. Note that contrary to MSVC, with MSYS all of the dependencies are not
|
||||||
built or used as static libaries. Currently Release build is used for all libraries.
|
built or used as static libraries. Currently Release build is used for all libraries.
|
||||||
|
|
||||||
### MSVC
|
### MSVC
|
||||||
Execute `build-deps.cmd` to fetch, build and install the dependencies. The batch file will print the requirements for
|
Execute `build-deps.cmd` to fetch, build and install the dependencies. The batch file will print the requirements for
|
||||||
@@ -28,7 +28,7 @@ deduced from the MSVC environment variables. User-friendly VS generator shorthan
|
|||||||
`vs2013-x86` or `vs2015-x64`, and these are converted to the appropriate CMake ones by the scripts. A build type
|
`vs2013-x86` or `vs2015-x64`, and these are converted to the appropriate CMake ones by the scripts. A build type
|
||||||
(`Build`, `Rebuild`, or `Clean`, defaults to `Build`) can be provided as `%3`. See `vs-cfg.cmd` if you wish to change
|
(`Build`, `Rebuild`, or `Clean`, defaults to `Build`) can be provided as `%3`. See `vs-cfg.cmd` if you wish to change
|
||||||
the defaults. The batch file will create `deps\` and `deps-vs<VERSION>-<ARCHITECTURE>-installed\` directories to the
|
the defaults. The batch file will create `deps\` and `deps-vs<VERSION>-<ARCHITECTURE>-installed\` directories to the
|
||||||
project root. Debug and release builds of the depedencies can co-exist by simply running
|
project root. Debug and release builds of the dependencies can co-exist by simply running
|
||||||
```
|
```
|
||||||
> build-deps.cmd <GENERATOR> Debug
|
> build-deps.cmd <GENERATOR> Debug
|
||||||
> build-deps.cmd <GENERATOR> <Release|RelWithDebInfo|MinSizeRel>
|
> build-deps.cmd <GENERATOR> <Release|RelWithDebInfo|MinSizeRel>
|
||||||
|
|||||||
Reference in New Issue
Block a user