Fix representation where removing a representation left objects with an empty mesh. Now a proper empty is used.

src/blenderbim/test/bim/feature/geometry.feature

@@ -84,6 +84,66 @@ Scenario: Switch representation - existing Blender modifiers must be purged
     And I press "bim.switch_representation(obj='IfcWall/Cube', ifc_definition_id={representation})"
     Then the object "IfcWall/Cube" has no modifiers
 
+Scenario: Remove representation - remove an active representation
+    Given an empty IFC project
+    And I add a cube
+    And the object "Cube" is selected
+    And I add an array modifier
+    And I set "scene.BIMRootProperties.ifc_class" to "IfcWall"
+    And I press "bim.assign_class"
+    When the variable "representation" is "{ifc}.by_type('IfcShapeRepresentation')[0].id()"
+    And I press "bim.remove_representation(representation_id={representation})"
+    Then the object "IfcWall/Cube" has no data
+
+Scenario: Remove representation - remove an unloaded representation
+    Given an empty IFC project
+    And I add a cube
+    And the object "Cube" is selected
+    And I add an array modifier
+    And I set "scene.BIMRootProperties.ifc_class" to "IfcWall"
+    And I press "bim.assign_class"
+    When the variable "representation" is "{ifc}.by_type('IfcShapeRepresentation')[1].id()"
+    And I press "bim.remove_representation(representation_id={representation})"
+    Then the object "IfcWall/Cube" has data which is an IFC representation
+
+Scenario: Remove representation - remove an instanced representation from an active type object
+    Given an empty IFC project
+    And I add a cube
+    And the object "Cube" is selected
+    And I set "scene.BIMRootProperties.ifc_product" to "IfcElementType"
+    And I set "scene.BIMRootProperties.ifc_class" to "IfcWallType"
+    And I press "bim.assign_class"
+    And I set "scene.BIMModelProperties.ifc_class" to "IfcWallType"
+    And the variable "cube" is "{ifc}.by_type('IfcWallType')[0].id()"
+    And I set "scene.BIMModelProperties.relating_type" to "{cube}"
+    And I press "bim.add_type_instance"
+    And I press "bim.add_type_instance"
+    And the object "IfcWallType/Cube" is selected
+    When the variable "representation" is "{ifc}.by_type('IfcWallType')[0].RepresentationMaps[1].MappedRepresentation.id()"
+    And I press "bim.remove_representation(representation_id={representation})"
+    Then the object "IfcWallType/Cube" has no data
+    Then the object "IfcWall/Instance" has no data
+    Then the object "IfcWall/Instance.001" has no data
+
+Scenario: Remove representation - remove an instanced representation from an active instance object
+    Given an empty IFC project
+    And I add a cube
+    And the object "Cube" is selected
+    And I set "scene.BIMRootProperties.ifc_product" to "IfcElementType"
+    And I set "scene.BIMRootProperties.ifc_class" to "IfcWallType"
+    And I press "bim.assign_class"
+    And I set "scene.BIMModelProperties.ifc_class" to "IfcWallType"
+    And the variable "cube" is "{ifc}.by_type('IfcWallType')[0].id()"
+    And I set "scene.BIMModelProperties.relating_type" to "{cube}"
+    And I press "bim.add_type_instance"
+    And I press "bim.add_type_instance"
+    And the object "IfcWall/Instance" is selected
+    When the variable "representation" is "{ifc}.by_type('IfcWall')[0].Representation.Representations[1].id()"
+    And I press "bim.remove_representation(representation_id={representation})"
+    Then the object "IfcWallType/Cube" has no data
+    Then the object "IfcWall/Instance" has no data
+    Then the object "IfcWall/Instance.001" has no data
+
 Scenario: Update representation - updating a tessellation
     Given an empty IFC project
     And I add a cube

src/blenderbim/test/bim/test_feature.py

@@ -356,6 +356,11 @@ def the_object_name_is_not_an_ifc_element(name):
     assert id == 0, f"The ID is {id}"
 
 
+@then(parsers.parse('the object "{name}" has no data'))
+def the_object_name_has_no_data(name):
+    assert the_object_name_exists(name).data is None
+
+
 @then(parsers.parse('the object "{name}" has data which is an IFC representation'))
 def the_object_name_is_not_an_ifc_element(name):
     id = the_object_name_exists(name).data.BIMMeshProperties.ifc_definition_id

src/blenderbim/test/tool/test_geometry.py

@@ -184,6 +184,26 @@ class TestGetCartesianPointCoordinateOffset(NewFile):
         assert subject.get_cartesian_point_coordinate_offset(obj) is None
 
 
+class TestGetElementType(NewFile):
+    def test_run(self):
+        bpy.ops.bim.create_project()
+        ifc = tool.Ifc.get()
+        element = ifc.createIfcWall()
+        type = ifc.createIfcWallType()
+        ifcopenshell.api.run("type.assign_type", ifc, related_object=element, relating_type=type)
+        assert subject.get_element_type(element) == type
+
+
+class TestGetElementsOfType(NewFile):
+    def test_run(self):
+        bpy.ops.bim.create_project()
+        ifc = tool.Ifc.get()
+        element = ifc.createIfcWall()
+        type = ifc.createIfcWallType()
+        ifcopenshell.api.run("type.assign_type", ifc, related_object=element, relating_type=type)
+        assert subject.get_elements_of_type(type) == (element,)
+
+
 class TestGetTotalRepresentationItems(NewFile):
     def test_run(self):
         material1 = bpy.data.materials.new("Material")
@@ -194,6 +214,14 @@ class TestGetTotalRepresentationItems(NewFile):
         assert subject.get_total_representation_items(obj) == 2
 
 
+class TestHasDataUsers(NewFile):
+    def test_run(self):
+        data = bpy.data.meshes.new("Mesh")
+        assert subject.has_data_users(data) is False
+        bpy.data.objects.new("Object", data)
+        assert subject.has_data_users(data) is True
+
+
 class TestImportRepresentation(NewFile):
     def test_importing_a_normal_shape(self):
         ifc = ifcopenshell.open("test/files/basic.ifc")
@@ -232,6 +260,22 @@ class TestIsBodyRepresentation(NewFile):
         assert subject.is_body_representation(representation) is False
 
 
+class TestIsMappedRepresentation(NewFile):
+    def test_run(self):
+        ifc = ifcopenshell.file()
+        representation = ifc.createIfcShapeRepresentation()
+        assert subject.is_mapped_representation(representation) is False
+        representation.RepresentationType = "MappedRepresentation"
+        assert subject.is_mapped_representation(representation) is True
+
+
+class TestIsTypeProduct(NewFile):
+    def test_run(self):
+        ifc = ifcopenshell.file()
+        assert subject.is_type_product(ifc.createIfcWall()) is False
+        assert subject.is_type_product(ifc.createIfcWallType()) is True
+
+
 class TestLink(NewFile):
     def test_run(self):
         ifc = ifcopenshell.file()
@@ -241,13 +285,31 @@ class TestLink(NewFile):
         assert obj.BIMMeshProperties.ifc_definition_id == element.id()
 
 
-class TestRenameObjectData(NewFile):
+class TestRenameObject(NewFile):
     def test_run(self):
         obj = bpy.data.meshes.new("Mesh")
         subject.rename_object(obj, "name")
         assert obj.name == "name"
 
 
+class TestReplaceObjectWithEmpty(NewFile):
+    def test_run(self):
+        ifc = ifcopenshell.file()
+        tool.Ifc.set(ifc)
+        obj = bpy.data.objects.new("Object", bpy.data.meshes.new("Mesh"))
+        obj.matrix_world[0][3] = 1
+        bpy.context.scene.collection.objects.link(obj)
+        element = ifc.createIfcWall()
+        tool.Ifc.link(element, obj)
+        subject.replace_object_with_empty(obj)
+        obj = bpy.data.objects.get("Object")
+        assert obj.users_collection[0] == bpy.context.scene.collection
+        assert tool.Ifc.get_entity(obj) == element
+        assert tool.Ifc.get_object(element) == obj
+        assert obj.data is None
+        assert obj.matrix_world[0][3] == 1
+
+
 class TestResolveMappedRepresentation(NewFile):
     def test_run(self):
         ifc = ifcopenshell.file()