From 81fdaea5f23c681ead277ca4f78c82e9800bbf80 Mon Sep 17 00:00:00 2001
From: Dion Moult <dion@thinkmoult.com>
Date: Sat, 30 Mar 2024 23:07:06 +1100
Subject: [PATCH] Fix #4323. Bug where running a filter could fail if you tried
 to compare values which had incompatible types.

---
 .../ifcopenshell/util/selector.py             | 50 +++++++++++--------
 1 file changed, 28 insertions(+), 22 deletions(-)

diff --git a/src/ifcopenshell-python/ifcopenshell/util/selector.py b/src/ifcopenshell-python/ifcopenshell/util/selector.py
index 4e7106558c..149e394c4e 100644
--- a/src/ifcopenshell-python/ifcopenshell/util/selector.py
+++ b/src/ifcopenshell-python/ifcopenshell/util/selector.py
@@ -697,31 +697,37 @@ class FacetTransformer(lark.Transformer):
         if isinstance(element_value, (list, tuple)):
             return any(self.compare(ev, comparison, value) for ev in element_value)
         elif isinstance(value, str):
-            if isinstance(element_value, int):
-                value = int(value)
-            elif isinstance(element_value, float):
-                value = float(value)
+            try:
+                if isinstance(element_value, int):
+                    value = int(value)
+                elif isinstance(element_value, float):
+                    value = float(value)
 
-            if isinstance(element_value, (int, float)):
-                operator = comparison.lstrip("!")
-                if operator == ">=":
-                    result = element_value >= value
-                elif operator == "<=":
-                    result = element_value <= value
-                elif operator == ">":
-                    result = element_value > value
-                elif operator == "<":
-                    result = element_value < value
-                else:
-                    result = element_value == value  # Tolerance?
-            elif isinstance(element_value, str):
-                operator = comparison.lstrip("!")
-                if operator == "*=":
-                    result = value in element_value
+                if isinstance(element_value, (int, float)):
+                    operator = comparison.lstrip("!")
+                    if operator == ">=":
+                        result = element_value >= value
+                    elif operator == "<=":
+                        result = element_value <= value
+                    elif operator == ">":
+                        result = element_value > value
+                    elif operator == "<":
+                        result = element_value < value
+                    else:
+                        result = element_value == value  # Tolerance?
+                elif isinstance(element_value, str):
+                    operator = comparison.lstrip("!")
+                    if operator == "*=":
+                        result = value in element_value
+                    else:
+                        result = element_value == value
                 else:
                     result = element_value == value
-            else:
-                result = element_value == value
+            except:
+                # Potentially they are trying to compare a value which cannot
+                # be legally casted to the element_value, or cannot use the
+                # `in` or more / less than comparison operators.
+                result = False
         elif isinstance(value, re.Pattern):
             result = bool(value.match(element_value)) if element_value is not None else False
         elif value in (None, True, False):