Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-28 03:05:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Mutex bug fixed so remove hack

Browse Source
This commit is contained in:
Dion Moult
2026-05-16 17:03:55 +10:00
parent 22f25f0098
commit 8242efac97
1 changed files with 1 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcviewer/GeometryStreamer.cpp
+1 -7
View File
@@ -403,12 +403,6 @@ void GeometryStreamer::run(const std::string& path, int num_threads) {
// Wire intersection checks is prohibitively slow on advanced breps. See bug #5999. // Wire intersection checks is prohibitively slow on advanced breps. See bug #5999.
settings.set("no-wire-intersection-check", true); settings.set("no-wire-intersection-check", true);
// @todo parallel mapping on RocksDB-backed files still races somewhere
// outside the instance cache, producing inconsistent shape counts. Force
// serial iteration for RocksDB until the read path is fully thread-safe.
const bool is_rocksdb = std::holds_alternative<ifcopenshell::impl::rocks_db_file_storage>(ifc_file_->storage_);
const int effective_threads = is_rocksdb ? 1 : num_threads;
// Mirror bonsai's IfcImporter.process_element_filter: walk IfcElement // Mirror bonsai's IfcImporter.process_element_filter: walk IfcElement
// (plus IfcProxy on IFC2X3/IFC4), drop IfcFeatureElement except // (plus IfcProxy on IFC2X3/IFC4), drop IfcFeatureElement except
// IfcSurfaceFeature, pick up spatial elements, and split elements // IfcSurfaceFeature, pick up spatial elements, and split elements
@@ -527,7 +521,7 @@ void GeometryStreamer::run(const std::string& path, int num_threads) {
ifc_file_.get(), geometry_library, iter_settings); ifc_file_.get(), geometry_library, iter_settings);
iterator = std::make_unique<IfcGeom::Iterator>( iterator = std::make_unique<IfcGeom::Iterator>(
std::move(kernel), iter_settings, ifc_file_.get(), std::move(kernel), iter_settings, ifc_file_.get(),
filters, effective_threads); filters, num_threads);
} catch (const std::exception& e) { } catch (const std::exception& e) {
emit errorOccurred(QString("Failed to create geometry iterator: %1").arg(e.what())); emit errorOccurred(QString("Failed to create geometry iterator: %1").arg(e.what()));
return false; return false;