From 82a6ddb01c695135b2391bf649dc0274269f8340 Mon Sep 17 00:00:00 2001
From: Blender Defender <contact.blenderdefender@gmail.com>
Date: Fri, 26 Jul 2024 15:30:51 +0200
Subject: [PATCH] feat: Make `sql_type` an enum property in the `Ifc2Sql`
 recipe

Since there is a limited number of choices, a string property wouldn't be very helpful. Use a dynamic enum property (which is adjusted according to which types of SQL are available) instead.
---
 src/ifcpatch/ifcpatch/recipes/Ifc2Sql.py | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/src/ifcpatch/ifcpatch/recipes/Ifc2Sql.py b/src/ifcpatch/ifcpatch/recipes/Ifc2Sql.py
index b8664de93e..b3e18714d0 100644
--- a/src/ifcpatch/ifcpatch/recipes/Ifc2Sql.py
+++ b/src/ifcpatch/ifcpatch/recipes/Ifc2Sql.py
@@ -22,6 +22,7 @@ import re
 import json
 import time
 import tempfile
+import typing
 import itertools
 import numpy as np
 import multiprocessing
@@ -33,15 +34,19 @@ import ifcopenshell.util.schema
 import ifcopenshell.util.attribute
 import ifcopenshell.util.placement
 
+SQLTypes = typing.Literal["SQLite", "MySQL"]
+
 try:
     import sqlite3
 except:
     print("No SQLite support")
+    SQLTypes = typing.Literal["MySQL"]
 
 try:
     import mysql.connector
 except:
     print("No MySQL support")
+    SQLTypes = typing.Literal["SQLite"]
 
 
 class Patcher:
@@ -50,7 +55,7 @@ class Patcher:
         src,
         file,
         logger,
-        sql_type: str = "sqlite",
+        sql_type: SQLTypes = "SQLite",
         host: str = "localhost",
         username: str = "root",
         password: str = "pass",
@@ -79,8 +84,8 @@ class Patcher:
           IfcRepresentation and IfcRepresentationItem classes. These tables are
           unnecessary if you are not interested in geometry.
 
-        :param sql_type: Choose between "sqlite" or "mysql"
-        :type sql_type: str
+        :param sql_type: Choose between "SQLite" or "MySQL"
+        :type sql_type: typing.Literal["SQLite", "MySQL"]
 
         Example:
 
@@ -92,7 +97,7 @@ class Patcher:
         self.src = src
         self.file = file
         self.logger = logger
-        self.sql_type = sql_type
+        self.sql_type = sql_type.lower()
         self.host = host
         self.username = username
         self.password = password