Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-08-09 17:31:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Reuse assign_control instead of creating IfcRelAssignsToControls

Browse Source
This commit is contained in:
Andrej730
2025-07-23 18:36:51 +05:00
parent c82191f40b
commit 84f6632c13
2 changed files with 4 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcopenshell-python/ifcopenshell/api/cost/add_cost_item.py
+2 -10
View File
@@ -16,9 +16,9 @@
# You should have received a copy of the GNU Lesser General Public License
# along with IfcOpenShell. If not, see <http://www.gnu.org/licenses/>.
import ifcopenshell.api.control
import ifcopenshell.api.root
import ifcopenshell.api.nest
import ifcopenshell.api.owner
import ifcopenshell.guid
from typing import Optional
@@ -59,15 +59,7 @@ def add_cost_item(
cost_item_ = ifcopenshell.api.root.create_entity(file, ifc_class="IfcCostItem")
if cost_schedule:
file.create_entity(
"IfcRelAssignsToControl",
**{
"GlobalId": ifcopenshell.guid.new(),
"OwnerHistory": ifcopenshell.api.owner.create_owner_history(file),
"RelatedObjects": [cost_item_],
"RelatingControl": cost_schedule,
},
)
ifcopenshell.api.control.assign_control(file, cost_schedule, cost_item_)
elif cost_item:
ifcopenshell.api.nest.assign_object(file, related_objects=[cost_item_], relating_object=cost_item)
return cost_item_
src/ifcopenshell-python/ifcopenshell/api/sequence/add_task.py
+2 -10
View File
@@ -16,9 +16,9 @@
# You should have received a copy of the GNU Lesser General Public License
# along with IfcOpenShell. If not, see <http://www.gnu.org/licenses/>.
import ifcopenshell.api.control
import ifcopenshell.api.root
import ifcopenshell.api.nest
import ifcopenshell.api.owner
import ifcopenshell
import ifcopenshell.guid
from typing import Optional
@@ -139,15 +139,7 @@ def add_task(
task.Identification = identification
task.IsMilestone = False
if work_schedule:
file.create_entity(
"IfcRelAssignsToControl",
**{
"GlobalId": ifcopenshell.guid.new(),
"OwnerHistory": ifcopenshell.api.owner.create_owner_history(file),
"RelatedObjects": [task],
"RelatingControl": work_schedule,
}
)
ifcopenshell.api.control.assign_control(file, work_schedule, task)
elif parent_task:
rel = ifcopenshell.api.nest.assign_object(
file,