Comment behaviour #7264

This commit is contained in:
Thomas Krijnen
2025-10-20 10:37:35 +02:00
committed by GitHub
parent 34f4aa430a
commit 86b89f2153
+2
View File
@@ -748,6 +748,7 @@ std::optional<std::tuple<size_t, const IfcParse::declaration*, IfcEntityInstance
IfcUtil::IfcBaseClass* IfcParse::impl::rocks_db_file_storage::create(const IfcParse::declaration* decl) { IfcUtil::IfcBaseClass* IfcParse::impl::rocks_db_file_storage::create(const IfcParse::declaration* decl) {
if (decl->as_entity() || decl->as_type_declaration()) { if (decl->as_entity() || decl->as_type_declaration()) {
auto* inst = file->schema()->instantiate(decl, rocks_db_attribute_storage{}); auto* inst = file->schema()->instantiate(decl, rocks_db_attribute_storage{});
// @todo maybe this needs to be set to file? In order to have a context (ie. rocksdb::db*) to write to?
inst->file_ = nullptr; inst->file_ = nullptr;
return file->addEntity(inst); return file->addEntity(inst);
} else { } else {
@@ -764,6 +765,7 @@ IfcUtil::IfcBaseClass* IfcParse::impl::in_memory_file_storage::create(const IfcP
} else { } else {
throw std::runtime_error("Requires and entity or type declaration"); throw std::runtime_error("Requires and entity or type declaration");
} }
// file_ should be nullptr in order not to bypass addEntity() behaviour of registration in maps
inst->file_ = nullptr; inst->file_ = nullptr;
return file->addEntity(inst); return file->addEntity(inst);
} }