From 8c692dfbb6615ef1d5ae006d69caa0f736b1c00b Mon Sep 17 00:00:00 2001 From: Dion Moult Date: Fri, 19 Jan 2024 22:24:47 +1100 Subject: [PATCH] Fix #4127. Bug where IfcTester couldn't save ODS report. --- src/ifctester/ifctester/reporter.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/ifctester/ifctester/reporter.py b/src/ifctester/ifctester/reporter.py index 97e01cb1f7..ff78d9c586 100644 --- a/src/ifctester/ifctester/reporter.py +++ b/src/ifctester/ifctester/reporter.py @@ -256,6 +256,7 @@ class Json(Reporter): { "reason": requirement.failed_reasons[i], "element": str(e), + "element_type": str(ifcopenshell.util.element.get_type(e)), "class": e.is_a(), "predefined_type": ifcopenshell.util.element.get_predefined_type(e), "name": getattr(e, "Name", None), @@ -395,7 +396,7 @@ class Ods(Json): continue for failure in requirement["failed_entities"]: element = failure.get("element", None) - element_type = ifcopenshell.util.element.get_type(failure.get("element", None)) + element_type = failure.get("element_type", None) row = [ requirement["description"], failure.get("reason", "No reason provided"),