Fix #4203. Fix bug where removing nested cost items left orphaned relationships.

This commit is contained in:
Dion Moult
2024-01-12 18:14:49 +11:00
parent 75dd4f3132
commit 8df40dc4a6
10 changed files with 198 additions and 13 deletions
@@ -22,7 +22,7 @@ from datetime import datetime
class Usecase:
def __init__(self, file, name=None, predefined_type="NOTDEFINED", object_type=None):
def __init__(self, file, name=None, predefined_type="NOTDEFINED"):
"""Add a new cost schedule
A cost schedule is a group of cost items which typically represent a
@@ -54,7 +54,7 @@ class Usecase:
item = ifcopenshell.api.run("cost.add_cost_item", model, cost_schedule=schedule)
"""
self.file = file
self.settings = {"name": name, "predefined_type": predefined_type, "object_type": object_type}
self.settings = {"name": name, "predefined_type": predefined_type}
def execute(self):
cost_schedule = ifcopenshell.api.run(
@@ -65,6 +65,4 @@ class Usecase:
name=self.settings["name"],
)
cost_schedule.UpdateDate = ifcopenshell.util.date.datetime2ifc(datetime.now(), "IfcDateTime")
if self.settings["object_type"]:
cost_schedule.ObjectType = self.settings["object_type"]
return cost_schedule
@@ -52,7 +52,7 @@ class Usecase:
if inverse.RelatingObject == self.settings["cost_item"]:
for related_object in inverse.RelatedObjects:
ifcopenshell.api.run("cost.remove_cost_item", self.file, cost_item=related_object)
elif inverse.RelatedObjects == tuple(self.settings["cost_item"]):
elif inverse.RelatedObjects == (self.settings["cost_item"],):
history = inverse.OwnerHistory
self.file.remove(inverse)
if history: