diff --git a/cmake/CMakeLists.txt b/cmake/CMakeLists.txt index bc6a02f4f4..ebb041c33f 100644 --- a/cmake/CMakeLists.txt +++ b/cmake/CMakeLists.txt @@ -184,7 +184,7 @@ IF(UNICODE_SUPPORT) MESSAGE(STATUS "ICU libraries found") # NOTE icudata appears to be icudt on Windows/MSVC and icudata on others # dl is included to resolve dlopen and friends symbols - IF(MSVC) + IF(MSVC OR MINGW) SET(ICU_LIBRARIES icuuc icudt) ADD_DEBUG_VARIANTS(ICU_LIBRARIES "${ICU_LIBRARIES}" "d") ADD_DEFINITIONS(-DU_STATIC_IMPLEMENTATION) # required for static ICU @@ -316,7 +316,12 @@ IF(MSVC) ENDIF() ENDFOREACH() ElSE() - ADD_DEFINITIONS(-fPIC -Wno-non-virtual-dtor) + IF(WIN32) + # -fPIC is not relevant on Windows and create pointless warnings + ADD_DEFINITIONS(-Wno-non-virtual-dtor) + ELSE() + ADD_DEFINITIONS(-fPIC -Wno-non-virtual-dtor) + ENDIF() ENDIF() INCLUDE_DIRECTORIES(${INCLUDE_DIRECTORIES} ${OCC_INCLUDE_DIR} ${OPENCOLLADA_INCLUDE_DIRS} diff --git a/src/ifcgeomserver/IfcGeomServer.cpp b/src/ifcgeomserver/IfcGeomServer.cpp index 0ffe057751..16e0f95d3a 100644 --- a/src/ifcgeomserver/IfcGeomServer.cpp +++ b/src/ifcgeomserver/IfcGeomServer.cpp @@ -27,9 +27,12 @@ #include #include -#if defined(_WIN32) && !defined(__CYGWIN__) +// NB: Streams are only re-opened as binary when compiled with MSVC currently. +// It is unclear what the correct behaviour would be compiled with e.g MinGW +#if defined(_MSC_VER) #define SET_BINARY_STREAMS #endif + #ifdef SET_BINARY_STREAMS #include #include diff --git a/src/ifcparse/IfcParse.cpp b/src/ifcparse/IfcParse.cpp index 1d19748245..6b9605c1a1 100644 --- a/src/ifcparse/IfcParse.cpp +++ b/src/ifcparse/IfcParse.cpp @@ -47,23 +47,53 @@ using namespace IfcParse; // strtod_l() is used and a reference to the "C" locale is obtained here. The alternative is // to use std::istringstream::imbue(std::locale::classic()), but there are subtleties in // parsing in MSVC2010 and it appears to be much slower. -#ifdef _MSC_VER +#if defined(_MSC_VER) + static _locale_t locale = (_locale_t) 0; void init_locale() { if (locale == (_locale_t) 0) { locale = _create_locale(LC_NUMERIC, "C"); } } + #else + +#if defined(__MINGW64__) || defined(__MINGW32__) +#include +#include + +typedef void* locale_t; +static locale_t locale = (locale_t)0; + +void init_locale() {} + +double strtod_l(const char* start, char** end, locale_t loc) { + double d; + std::stringstream ss; + ss.imbue(std::locale::classic()); + ss << start; + ss >> d; + size_t nread = ss.tellg(); + *end = const_cast(start) + nread; + return d; +} + +#else + #ifdef __APPLE__ #include #endif -static locale_t locale = (locale_t) 0; +#include + +static locale_t locale = (locale_t)0; void init_locale() { - if (locale == (locale_t) 0) { - locale = newlocale(LC_NUMERIC_MASK, "C", (locale_t) 0); + if (locale == (locale_t)0) { + locale = newlocale(LC_NUMERIC_MASK, "C", (locale_t)0); } } + +#endif + #endif //