From 90946e0877cf70d3ea0b6d1aa7fa4547146dbd4f Mon Sep 17 00:00:00 2001 From: Stinkfist0 Date: Fri, 20 Nov 2015 00:45:01 +0200 Subject: [PATCH] Windows build scripts: TODO & indentation tweaks. --- win/build-deps.cmd | 10 +++++----- win/run-cmake.bat | 2 +- win/vs-cfg.cmd | 1 - 3 files changed, 6 insertions(+), 7 deletions(-) diff --git a/win/build-deps.cmd b/win/build-deps.cmd index 46c03fe050..8e4b6b1133 100644 --- a/win/build-deps.cmd +++ b/win/build-deps.cmd @@ -97,20 +97,20 @@ call cecho.cmd 0 13 "* Installation Directory = %INSTALL_DIR%" echo - The directory where %PROJECT_NAME% dependencies are installed. call cecho.cmd 0 13 "* Build Config Type`t= %BUILD_CFG%" echo - The used build configuration type for the dependencies. -echo Defaults to RelWithDebInfo if not specified. +echo Defaults to RelWithDebInfo if not specified. IF %BUILD_CFG%==MinSizeRel call cecho.cmd 0 14 " WARNING: MinSizeRel build can suffer from a significant performance loss." call cecho.cmd 0 13 "* Build Type`t`t= %BUILD_TYPE%" echo - The used build type for the dependencies (Build, Rebuild, Clean). -echo Defaults to Build if not specified. Rebuild/Clean also uninstalls Python (if it was installed by this script). +echo Defaults to Build if not specified. Rebuild/Clean also uninstalls Python (if it was installed by this script). call cecho.cmd 0 13 "* IFCOS_INSTALL_PYTHON`t= %IFCOS_INSTALL_PYTHON%" echo - Download and install Python. -echo Set to something other than TRUE if you wish to use an already installed version of Python. +echo Set to something other than TRUE if you wish to use an already installed version of Python. call cecho.cmd 0 13 "* IFCOS_USE_PYTHON2`t= %IFCOS_USE_PYTHON2%" echo - Use Python 2 instead of 3. -echo Set to TRUE if you wish to use Python 2 instead of 3. Has no effect if IFCOS_INSTALL_PYTHON is not TRUE. +echo Set to TRUE if you wish to use Python 2 instead of 3. Has no effect if IFCOS_INSTALL_PYTHON is not TRUE. call cecho.cmd 0 13 "* IFCOS_NUM_BUILD_PROCS`t= %IFCOS_NUM_BUILD_PROCS%" echo - How many MSBuild.exe processes may be run in parallel. -echo Defaults to NUMBER_OF_PROCESSORS. +echo Defaults to NUMBER_OF_PROCESSORS. echo. :: Print script's usage information diff --git a/win/run-cmake.bat b/win/run-cmake.bat index 80518dab05..3ee00e731a 100644 --- a/win/run-cmake.bat +++ b/win/run-cmake.bat @@ -24,7 +24,7 @@ set PROJECT_NAME=IfcOpenShell :: Enable the delayed environment variable expansion needed in vs-cfg.cmd. setlocal EnableDelayedExpansion - +:: TODO Getting warning print in vs-cfg.cmd for missing build type although this script doesn't need it specified call vs-cfg.cmd %1 :: Read Python related variables from BuildDepsCache.txt diff --git a/win/vs-cfg.cmd b/win/vs-cfg.cmd index 88b025eed0..8f5b93f2a2 100644 --- a/win/vs-cfg.cmd +++ b/win/vs-cfg.cmd @@ -32,7 +32,6 @@ set GENERATOR=%1 :: F.ex. "vs2013-32" and/or "vc14-64" :: TODO Print CMake and VS versions. Maybe in build-deps.cmd would be better than here. -:: Make CMake missing a fatal error and abort the script. :: Supported Visual Studio versions: set GENERATOR_VS2015_32="Visual Studio 14 2015"