SplitByBuildingStorey - fix errors, fix Bonsai UI #4721

- The patch was failed when executed from Bonsai since self.src wasn't provided, fixed now.
- Added a temporary hack to diplsay file selector for this patch.
- small refactor.
This commit is contained in:
Andrej730
2024-12-05 17:16:21 +05:00
parent 13106d255c
commit 939cc63cae
3 changed files with 53 additions and 16 deletions
+12 -2
View File
@@ -79,7 +79,12 @@ class ExecuteIfcPatch(bpy.types.Operator):
props = context.scene.BIMPatchProperties
arguments = []
if props.ifc_patch_args_attr:
arguments = [arg.get_value() for arg in props.ifc_patch_args_attr]
arguments = []
for arg in props.ifc_patch_args_attr:
value = arg.get_value()
if arg.data_type == "file" and arg.metadata == "single_file":
value = value[0]
arguments.append(value)
if props.should_load_from_memory and tool.Ifc.get():
input_file = props.ifc_patch_input
@@ -123,8 +128,13 @@ class UpdateIfcPatchArguments(bpy.types.Operator):
arg_info = inputs[arg_name]
new_attr = patch_args.add()
data_type = arg_info.get("type", "str")
if tool.Patch.is_filepath_argument(self.recipe, arg_name):
data_type = "file"
new_attr.metadata = "single_file"
if isinstance(data_type, list):
if "file" in data_type:
if "file" in data_type or tool.Patch.is_filepath_argument(self.recipe, arg_name):
data_type = ["file"]
data_type = [dt for dt in data_type if dt != "NoneType"][0]
+7
View File
@@ -29,3 +29,10 @@ class Patch(bonsai.core.tool.Patch):
{"input": infile, "file": ifcopenshell.open(infile), "recipe": "Migrate", "arguments": [schema]}
)
ifcpatch.write(output, outfile)
@classmethod
def is_filepath_argument(cls, recipe: str, arg_name: str) -> bool:
# TODO: Temporary hack to identify filepath arguments.
# Should mark them as such in the patches documentation
# and process it later.
return recipe == "SplitByBuildingStorey" and arg_name == "output_dir"