Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-21 14:23:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix bug where removing a context (used by representations) left invalid representations

Browse Source
This commit is contained in:
Dion Moult
2025-04-01 17:28:22 +11:00
parent 16f09655b8
commit 93e7d92076
2 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcopenshell-python/ifcopenshell/api/context/remove_context.py
+4 -2
View File
@@ -59,5 +59,7 @@ def remove_context(file: ifcopenshell.file, context: ifcopenshell.entity_instanc
else: else:
representations_in_context = context.RepresentationsInContext representations_in_context = context.RepresentationsInContext
file.remove(context) file.remove(context)
for element in representations_in_context: for rep in representations_in_context:
ifcopenshell.api.geometry.remove_representation(file, representation=element) for element in ifcopenshell.util.element.get_elements_by_representation(file, rep):
ifcopenshell.api.geometry.unassign_representation(file, product=element, representation=rep)
ifcopenshell.api.geometry.remove_representation(file, representation=rep)
src/ifcopenshell-python/test/api/context/test_remove_context.py
+8 -3
View File
@@ -48,11 +48,16 @@ class TestRemoveContext(test.bootstrap.IFC4):
assert len(self.file.by_type("IfcMapConversion")) == 0 assert len(self.file.by_type("IfcMapConversion")) == 0
assert len(self.file.by_type("IfcProjectedCRS")) == 0 assert len(self.file.by_type("IfcProjectedCRS")) == 0
def test_removing_a_context_with_references(self): def test_removing_a_context_with_assigned_representations(self):
context = self.file.createIfcGeometricRepresentationContext() context = self.file.createIfcGeometricRepresentationContext()
representation = self.file.createIfcRepresentation(ContextOfItems=context) element = ifcopenshell.api.root.create_entity(self.file)
rep = self.file.createIfcRepresentation(ContextOfItems=context)
ifcopenshell.api.geometry.assign_representation(self.file, product=element, representation=rep)
ifcopenshell.api.context.remove_context(self.file, context=context) ifcopenshell.api.context.remove_context(self.file, context=context)
assert len([e for e in self.file]) == 0 if self.file.schema == "IFC2X3":
assert len([e for e in self.file]) == 6
else:
assert len([e for e in self.file]) == 1
class TestRemoveContextIFC2X3(test.bootstrap.IFC2X3, TestRemoveContext): class TestRemoveContextIFC2X3(test.bootstrap.IFC2X3, TestRemoveContext):