Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-23 09:32:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixes IfcAxis2PlacementLinear per https://github.com/buildingSMART/IFC4.3.x-development/issues/732#issuecomment-1812127613

Browse Source
This commit is contained in:
Richard Brice
2024-03-27 16:23:04 -07:00
parent 4b32381192
commit 960a59da84
1 changed files with 41 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcgeom/mapping/IfcAxis2PlacementLinear.cpp
+41 -26
View File
@@ -30,41 +30,56 @@ taxonomy::ptr mapping::map_impl(const IfcSchema::IfcAxis2PlacementLinear* inst)
Eigen::Vector3d o, axis(0, 0, 1), refDirection; Eigen::Vector3d o, axis(0, 0, 1), refDirection;
taxonomy::matrix4::ptr m = taxonomy::cast<taxonomy::matrix4>(map(inst->Location())); taxonomy::matrix4::ptr m = taxonomy::cast<taxonomy::matrix4>(map(inst->Location()));
o = m->components().col(3).head<3>(); o = m->components().col(3).head<3>();
const bool hasAxis = !!inst->Axis(); // From 8.9.3.4 IfcAxis2PlacementLinear there are 4 cases that need to be considered
const bool hasRef = !!inst->RefDirection(); // 1) Axis is given but not RefDirection
// 2) RefDirection is given but not Axis
// 3) Neither Axis or RefDirection are provided
// 4) Both Axis and RefDirection are provided
const bool hasAxis = inst->Axis() != nullptr;
const bool hasRef = inst->RefDirection() != nullptr;
if (hasAxis != hasRef) { if (hasAxis != hasRef) {
Logger::Warning("Axis and RefDirection should be specified together", inst); Logger::Warning("Axis and RefDirection should be specified together", inst);
} }
if (hasAxis) { if (hasAxis && !hasRef)
taxonomy::direction3::ptr v = taxonomy::cast<taxonomy::direction3>(map(inst->Axis())); {
axis = *v->components_; taxonomy::direction3::ptr a = taxonomy::cast<taxonomy::direction3>(map(inst->Axis()));
} else { axis = *a->components_;
// 8.9.3.4 IfcAxis2LinearPlacement does not specify the default when Axis is omitted
// When RefDirection is omitted, see comment below, it is taken to be tangent to the curve.
// To be consistent, Axis is taken to be orthogonal to RefDirection
axis = m->components().col(2).head<3>();
}
if (hasRef) { refDirection = m->components().col(0).head<3>(); // RefDirection is the curve tangent when omitted
taxonomy::direction3::ptr v = taxonomy::cast<taxonomy::direction3>(map(inst->RefDirection())); // refDirection is not necessarily orthogonal to axis.
refDirection = *v->components_; // axis.cross(refDirection) gives y. y.cross(axis) gives x=refDirection
} else { refDirection = axis.cross(refDirection).cross(axis);
// 8.9.3.4 IfcAxis2LinearPlacement }
// https://standards.buildingsmart.org/IFC/RELEASE/IFC4_3/HTML/lexical/IfcAxis2PlacementLinear.htm else if (!hasAxis && hasRef)
// "If RefDirection is omitted, the direction is taken from the curve tangent at Location" {
// taxonomy::direction3::ptr r = taxonomy::cast<taxonomy::direction3>(map(inst->RefDirection()));
// When the PointByDistanceExpression Location is evaluated, it is evaluating the basis curve and returning refDirection = *r->components_;
// the matrix of orthogonal vectors that define the coordinate system at the point on curve as well as the point on curve Eigen::Vector3d up(0, 0, 1);
// In other words, the m matrix has everything needed axis = refDirection.cross(up.cross(refDirection));
}
else if (!hasAxis && !hasRef)
{
refDirection = m->components().col(0).head<3>(); // RefDirection is the curve tangent when omitted
Eigen::Vector3d up(0, 0, 1);
axis = refDirection.cross(up.cross(refDirection));
}
else
{
taxonomy::direction3::ptr a = taxonomy::cast<taxonomy::direction3>(map(inst->Axis()));
axis = *a->components_;
refDirection = m->components().col(0).head<3>(); taxonomy::direction3::ptr r = taxonomy::cast<taxonomy::direction3>(map(inst->RefDirection()));
refDirection = *r->components_;
refDirection = axis.cross(refDirection).cross(axis); // refDirection needs to be orthogonal to axis
}
} // axis and refDirection need to be orthogonal
return taxonomy::make<taxonomy::matrix4>(o, axis, refDirection); return taxonomy::make<taxonomy::matrix4>(o, axis, refDirection);
} }