Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-24 17:29:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

#2224 Optimise import by 10-40% by removing unnecessary slow traversal of representations

Browse Source
This commit is contained in:
Dion Moult
2022-06-08 09:14:36 +10:00
parent 2ab808a216
commit 96e4641ebf
1 changed files with 26 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/blenderbim/blenderbim/bim/import_ifc.py
+26 -7
View File
@@ -121,7 +121,14 @@ class MaterialCreator:
def parse_representation_item(self, item): def parse_representation_item(self, item):
if not item.StyledByItem: if not item.StyledByItem:
return return
style_ids = [e.id() for e in self.ifc_importer.file.traverse(item.StyledByItem[0]) if e.is_a("IfcSurfaceStyle")] style_ids = []
styles = list(item.StyledByItem[0].Styles)
while styles:
style = styles.pop()
if style.is_a("IfcSurfaceStyle"):
style_ids.append(style.id())
elif style.is_a("IfcPresentationStyleAssignment"):
styles.extend(style.Styles)
if not style_ids: if not style_ids:
return return
for style_id in style_ids: for style_id in style_ids:
@@ -873,8 +880,13 @@ class IfcImporter:
def get_representation_item_material_name(self, item): def get_representation_item_material_name(self, item):
if not item.StyledByItem: if not item.StyledByItem:
return return
style_ids = [e.id() for e in self.file.traverse(item.StyledByItem[0]) if e.is_a("IfcSurfaceStyle")] styles = list(item.StyledByItem[0].Styles)
return style_ids[0] if style_ids else None while styles:
style = styles.pop()
if style.is_a("IfcSurfaceStyle"):
return style.id()
elif style.is_a("IfcPresentationStyleAssignment"):
styles.extend(style.Styles)
def create_native_faceted_brep(self, element, mesh_name): def create_native_faceted_brep(self, element, mesh_name):
# TODO: georeferencing? # TODO: georeferencing?
@@ -1304,11 +1316,18 @@ class IfcImporter:
for material_definition_representation in self.file.by_type("IfcMaterialDefinitionRepresentation"): for material_definition_representation in self.file.by_type("IfcMaterialDefinitionRepresentation"):
material = material_definition_representation.RepresentedMaterial material = material_definition_representation.RepresentedMaterial
blender_material = self.material_creator.materials[material.id()]
for representation in material_definition_representation.Representations: for representation in material_definition_representation.Representations:
for style in [e for e in self.file.traverse(representation) if e.is_a("IfcSurfaceStyle")]: styles = []
blender_material = self.material_creator.materials[material.id()] for styled_item in representation.Items:
self.create_style(style, blender_material) styles.extend(styled_item.Styles)
parsed_styles.add(style.id()) while styles:
style = styles.pop()
if style.is_a("IfcSurfaceStyle"):
self.create_style(style, blender_material)
parsed_styles.add(style.id())
elif style.is_a("IfcPresentationStyleAssignment"):
styles.extend(style.Styles)
for style in self.file.by_type("IfcSurfaceStyle"): for style in self.file.by_type("IfcSurfaceStyle"):
if style.id() in parsed_styles: if style.id() in parsed_styles: