Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-26 18:21:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Skip degenerate triangles in IfcTriangulatedFaceSet #934

Browse Source
This commit is contained in:
Thomas Krijnen
2020-08-03 10:57:10 +02:00
parent 0d28978a48
commit 97f03d3933
1 changed files with 19 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcgeom/IfcGeomShapes.cpp
+19 -1
View File
@@ -1504,11 +1504,29 @@ bool IfcGeom::Kernel::convert(const IfcSchema::IfcTriangulatedFaceSet* l, TopoDS
return false; return false;
} }
if (tri[0] == tri[1] || tri[1] == tri[2] || tri[0] == tri[2]) {
auto tri_0 = boost::lexical_cast<std::string>(tri[0]);
auto tri_1 = boost::lexical_cast<std::string>(tri[1]);
auto tri_2 = boost::lexical_cast<std::string>(tri[2]);
Logger::Message(Logger::LOG_ERROR, "Degenerate triangle indices, skipping (" + tri_0 + "," + tri_1 + "," + tri_2 + ")", l);
continue;
}
const gp_Pnt& a = points[tri[0] - 1]; // account for zero- vs const gp_Pnt& a = points[tri[0] - 1]; // account for zero- vs
const gp_Pnt& b = points[tri[1] - 1]; // one-based indices in const gp_Pnt& b = points[tri[1] - 1]; // one-based indices in
const gp_Pnt& c = points[tri[2] - 1]; // c++ and express const gp_Pnt& c = points[tri[2] - 1]; // c++ and express
TopoDS_Wire wire = BRepBuilderAPI_MakePolygon(a, b, c, true).Wire(); BRepBuilderAPI_MakePolygon mp(a, b, c, true);
if (!mp.IsDone()) {
auto tri_0 = boost::lexical_cast<std::string>(tri[0]);
auto tri_1 = boost::lexical_cast<std::string>(tri[1]);
auto tri_2 = boost::lexical_cast<std::string>(tri[2]);
Logger::Message(Logger::LOG_ERROR, "Degenerate triangle, skipping (" + tri_0 + "," + tri_1 + "," + tri_2 + ")", l);
continue;
}
TopoDS_Wire wire = mp.Wire();
TopoDS_Face face = BRepBuilderAPI_MakeFace(wire).Face(); TopoDS_Face face = BRepBuilderAPI_MakeFace(wire).Face();
TopoDS_Iterator face_it(face, false); TopoDS_Iterator face_it(face, false);