Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-08-10 17:58:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Minor structural code review

Browse Source
This commit is contained in:
Dion Moult
2021-05-06 18:24:13 +10:00
parent 8a3e023408
commit 992474fbf2
7 changed files with 70 additions and 63 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcopenshell-python/ifcopenshell/api/structural/data.py
+6 -6
View File
@@ -101,9 +101,9 @@ class Data:
def load_structural_load_case_combinations(cls):
cls.load_case_combinations = {}
for case in cls._file.by_type("IfcStructuralLoadGroup"):
for case in cls._file.by_type("IfcStructuralLoadGroup", include_subtypes=False):
if case.PredefinedType != "LOAD_COMBINATION":
return
continue
data = case.get_info()
del data["OwnerHistory"]
@@ -118,9 +118,9 @@ class Data:
def load_structural_load_groups(cls):
cls.load_groups = {}
for case in cls._file.by_type("IfcStructuralLoadGroup"):
if case.PredefinedType != "LOAD_COMBINATION":
return
for case in cls._file.by_type("IfcStructuralLoadGroup", include_subtypes=False):
if case.PredefinedType == "LOAD_COMBINATION":
continue
# if case.IsGroupedBy:
# for rel in case.IsGroupedBy:
# for product in rel.RelatedObjects:
@@ -213,4 +213,4 @@ class Data:
cls.load_connects_structural_activity(activity)
member_data["ConnectsStructuralActivities"].append(activity.id())
cls.members[member.id()] = member_data
cls.members[member.id()] = member_data