From 998060b686e22297a04eabb8154f50fdf5868641 Mon Sep 17 00:00:00 2001 From: Andrej730 Date: Wed, 16 Sep 2026 17:36:25 +0500 Subject: [PATCH] ifcparse: drop dllexport from instance_streamer class template Fixes the following compilation error when building on MSVC with `USE_MMAP`. ``` parse.cpp(2202,23): error C2338: static_assert failed: 'Default instance_streamer requires a pushed sequential reader' ``` Apparently, when class has `IFC_PARSE_API`, compiler is very eager to instantiate all possible templates leading to this error. We already have explicit instantiation with export for the ones we actually use (e.g. `template class IFC_PARSE_API ifcopenshell::instance_streamer>;`), so it should be no-op. --- src/ifcparse/file.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ifcparse/file.h b/src/ifcparse/file.h index bca196f98a..852b74f28b 100644 --- a/src/ifcparse/file.h +++ b/src/ifcparse/file.h @@ -91,7 +91,7 @@ enum filetype { IFC_PARSE_API filetype guess_file_type(const std::string& path); template > -class IFC_PARSE_API instance_streamer { +class instance_streamer { private: std::unique_ptr owned_stream_; Reader* stream_;