Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-25 08:02:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Support evaluation of faces directly, add identity matrix on unplaced circle profile curves #4832

Browse Source
This commit is contained in:
Thomas Krijnen
2024-06-18 12:31:04 +02:00
parent 17a433a97b
commit 9c22e6ecc8
2 changed files with 5 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcgeom/kernels/opencascade/face.cpp
+2 -21
View File
@@ -306,33 +306,14 @@ bool OpenCascadeKernel::convert(const taxonomy::face::ptr face, TopoDS_Shape& re
} }
bool OpenCascadeKernel::convert_impl(const taxonomy::face::ptr face, IfcGeom::ConversionResults& results) { bool OpenCascadeKernel::convert_impl(const taxonomy::face::ptr face, IfcGeom::ConversionResults& results) {
throw std::runtime_error("Root-level face not expected"); TopoDS_Shape shape;
/* if (!convert(face, shape)) {
// Root level faces are only encountered in case of half spaces
// @todo this is not true, halfspace will be solid>face
if (face->basis == nullptr) {
Logger::Error("Half space without underlying surface:", face->instance);
return false; return false;
} }
if (face->basis->kind() != taxonomy::PLANE) {
Logger::Message(Logger::LOG_ERROR, "Unsupported BaseSurface:", face->basis->instance);
return false;
}
// @todo boundary
const auto& m = ((taxonomy::geom_ptr)face->basis)->matrix.ccomponents();
gp_Pln pln(convert_xyz2<gp_Pnt>(m.col(3)), convert_xyz2<gp_Dir>(m.col(2)));
const gp_Pnt pnt = pln.Location().Translated(face->orientation.get_value_or(false) ? -pln.Axis().Direction() : pln.Axis().Direction());
TopoDS_Shape shape = BRepPrimAPI_MakeHalfSpace(BRepBuilderAPI_MakeFace(pln), pnt).Solid();
results.emplace_back(ConversionResult( results.emplace_back(ConversionResult(
face->instance->data().id(), face->instance->data().id(),
new OpenCascadeShape(shape), new OpenCascadeShape(shape),
face->surface_style face->surface_style
)); ));
return true; return true;
*/
} }
src/ifcgeom/mapping/IfcCircleProfileDef.cpp
+3
View File
@@ -46,6 +46,9 @@ taxonomy::ptr mapping::map_impl(const IfcSchema::IfcCircleProfileDef* inst) {
#endif #endif
if (has_position) { if (has_position) {
c->matrix = taxonomy::cast<taxonomy::matrix4>(map(inst->Position())); c->matrix = taxonomy::cast<taxonomy::matrix4>(map(inst->Position()));
} else {
// matrix needs to be set on elementary curves
c->matrix = taxonomy::make<taxonomy::matrix4>();
} }
auto e = taxonomy::make<taxonomy::edge>(); auto e = taxonomy::make<taxonomy::edge>();