Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-28 19:27:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix some warnings

Browse Source
This commit is contained in:
Thomas Krijnen
2018-12-12 16:12:38 +01:00
parent a8f4f0270a
commit a0f37cf9ea
3 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cmake/CMakeLists.txt
+1 -1
View File
@@ -413,7 +413,7 @@ IF(MSVC)
ENDIF() ENDIF()
ENDFOREACH() ENDFOREACH()
ElSE() ElSE()
add_definitions(-Wall -Wextra) add_definitions(-Wall -Wextra -Wno-maybe-uninitialized)
if (CMAKE_CXX_COMPILER_ID MATCHES "Clang") if (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
add_definitions(-Wno-tautological-constant-out-of-range-compare) add_definitions(-Wno-tautological-constant-out-of-range-compare)
endif() endif()
src/ifcgeom/IfcGeomIterator.h
+1 -1
View File
@@ -155,8 +155,8 @@ namespace IfcGeom {
Iterator(const IteratorSettings& settings, IfcParse::IfcFile* file, std::vector<IfcGeom::filter_t>& filters) Iterator(const IteratorSettings& settings, IfcParse::IfcFile* file, std::vector<IfcGeom::filter_t>& filters)
: settings(settings) : settings(settings)
, ifc_file(file) , ifc_file(file)
, owns_ifc_file(false)
, filters_(filters) , filters_(filters)
, owns_ifc_file(false)
{ {
_initialize(); _initialize();
} }
src/ifcgeom/IfcGeomWires.cpp
+2 -4
View File
@@ -128,7 +128,7 @@ namespace {
Handle(Geom_Curve) crv = BRep_Tool::Curve(e, _, __); Handle(Geom_Curve) crv = BRep_Tool::Curve(e, _, __);
const bool is_line = crv->DynamicType() == STANDARD_TYPE(Geom_Line); const bool is_line = crv->DynamicType() == STANDARD_TYPE(Geom_Line);
const bool is_circle = crv->DynamicType() == STANDARD_TYPE(Geom_Circle); const bool is_circle = crv->DynamicType() == STANDARD_TYPE(Geom_Circle);
all_linear = all_linear && all_linear; all_linear = all_linear && is_line;
single_circle = first && is_circle; single_circle = first && is_circle;
} }
@@ -209,7 +209,7 @@ namespace {
double dist = p1.Distance(p2); double dist = p1.Distance(p2);
// Distance is within 2p, this is fine // Distance is within tolerance, this is fine
if (dist < p_) { if (dist < p_) {
mw_.Add(w1); mw_.Add(w1);
goto check; goto check;
@@ -403,8 +403,6 @@ bool IfcGeom::Kernel::convert(const IfcSchema::IfcCompositeCurve* l, TopoDS_Wire
BRepBuilderAPI_MakeWire w; BRepBuilderAPI_MakeWire w;
TopoDS_Vertex wire_first_vertex, wire_last_vertex, edge_first_vertex, edge_last_vertex; TopoDS_Vertex wire_first_vertex, wire_last_vertex, edge_first_vertex, edge_last_vertex;
const double precision_sq_2 = 2 * getValue(GV_PRECISION) * getValue(GV_PRECISION);
TopTools_ListIteratorOfListOfShape it(converted_segments); TopTools_ListIteratorOfListOfShape it(converted_segments);
IfcEntityList::ptr profile = l->entity->getInverse(IfcSchema::Type::IfcProfileDef, -1); IfcEntityList::ptr profile = l->entity->getInverse(IfcSchema::Type::IfcProfileDef, -1);