Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-19 06:39:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixes for closed/non-periodic nurbs curve edges #586

Browse Source
This commit is contained in:
Thomas Krijnen
2019-11-05 15:13:34 +01:00
parent ee79401a34
commit a1253b004d
2 changed files with 15 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcgeom/IfcGeomCurves.cpp
+3 -1
View File
@@ -157,7 +157,9 @@ bool IfcGeom::Kernel::convert(const IfcSchema::IfcBSplineCurveWithKnots* l, Hand
TColStd_Array1OfReal Knots(0, (int)knots.size() - 1); TColStd_Array1OfReal Knots(0, (int)knots.size() - 1);
TColStd_Array1OfInteger Mults(0, (int)mults.size() - 1); TColStd_Array1OfInteger Mults(0, (int)mults.size() - 1);
Standard_Integer Degree = l->Degree(); Standard_Integer Degree = l->Degree();
Standard_Boolean Periodic = l->ClosedCurve(); Standard_Boolean Periodic = false;
// @tfk: it appears to be wrong to expect a period curve when the curve is closed, see #586
// Standard_Boolean Periodic = l->ClosedCurve();
int i; int i;
src/ifcgeom/IfcGeomWires.cpp
+12 -6
View File
@@ -764,13 +764,19 @@ bool IfcGeom::Kernel::convert(const IfcSchema::IfcEdgeCurve* l, TopoDS_Wire& res
continue; continue;
} }
BRep_Builder builder; if (ecrv->IsClosed() && a.Distance(b) < getValue(GV_PRECISION)) {
TopoDS_Vertex v1, v2; // When vertices are close enough and the curve is closed,
/// @todo project first and emit warnings accordingly // use the entire curve.
builder.MakeVertex(v1, a, getValue(GV_PRECISION)); mw.Add(BRepBuilderAPI_MakeEdge(ecrv));
builder.MakeVertex(v2, b, getValue(GV_PRECISION)); } else {
BRep_Builder builder;
TopoDS_Vertex v1, v2;
/// @todo project first and emit warnings accordingly
builder.MakeVertex(v1, a, getValue(GV_PRECISION));
builder.MakeVertex(v2, b, getValue(GV_PRECISION));
mw.Add(BRepBuilderAPI_MakeEdge(ecrv, v1, v2)); mw.Add(BRepBuilderAPI_MakeEdge(ecrv, v1, v2));
}
first = false; first = false;
} }