Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-22 05:00:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove assumptions on solid topology in SVG camera frustrum detection #4924

Browse Source
This commit is contained in:
Thomas Krijnen
2024-07-03 20:03:06 +02:00
parent 813a8e12ed
commit a4532cc722
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/serializers/SvgSerializer.cpp
+9 -1
View File
@@ -434,6 +434,12 @@ namespace {
}; };
boost::optional<box_t> box_from_compound(TopoDS_Shape& compound) { boost::optional<box_t> box_from_compound(TopoDS_Shape& compound) {
/*
// in v0.8 apparently we don't get a solid/shell anymore because
// we no longer use PrimAPI, but rather resolve the box to an
// explicit shell with 6 faces in the mapping, which - depending
// on settings - may remain solely a compound of 6.
TopExp_Explorer exp(compound, TopAbs_SHELL); TopExp_Explorer exp(compound, TopAbs_SHELL);
TopoDS_Shell shell; TopoDS_Shell shell;
if (exp.More()) { if (exp.More()) {
@@ -446,12 +452,14 @@ namespace {
else { else {
return boost::none; return boost::none;
} }
*/
auto& shell = compound;
if (IfcGeom::util::count(shell, TopAbs_FACE) != 6) { if (IfcGeom::util::count(shell, TopAbs_FACE) != 6) {
return boost::none; return boost::none;
} }
TopoDS_Iterator it(shell); TopExp_Explorer it(shell, TopAbs_FACE);
for (; it.More(); it.Next()) { for (; it.More(); it.Next()) {
const auto& face = TopoDS::Face(it.Value()); const auto& face = TopoDS::Face(it.Value());
auto surf = BRep_Tool::Surface(face); auto surf = BRep_Tool::Surface(face);