Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-08-11 18:16:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

rename get_elements_using_pset -> get_elements_by_pset for consistency

Browse Source 
To be consistent with other get_elements_by_xxx methods.
This commit is contained in:
Andrej730
2024-09-05 17:38:22 +05:00
parent a03c55d15f
commit a867e72fd3
9 changed files with 16 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcpatch/ifcpatch/recipes/UnsharePsets.py
+1 -1
View File
@@ -65,7 +65,7 @@ class Patcher:
all_psets = self.file.by_type("IfcPropertySetDefinition")
psets: dict[ifcopenshell.entity_instance, set[ifcopenshell.entity_instance]] = {}
for pset in all_psets:
elements = ifcopenshell.util.element.get_elements_using_pset(pset)
elements = ifcopenshell.util.element.get_elements_by_pset(pset)
# Skip non shared psets.
if len(elements) < 2:
continue
src/ifcpatch/test/test_UnsharePsets.py
+3 -3
View File
@@ -38,7 +38,7 @@ class TestUnsharePsets(test.bootstrap.IFC4):
used_elements = set()
for pset in psets:
pset_elements = ifcopenshell.util.element.get_elements_using_pset(pset)
pset_elements = ifcopenshell.util.element.get_elements_by_pset(pset)
assert len(pset_elements) == 1
used_elements.update(pset_elements)
@@ -81,13 +81,13 @@ class TestUnsharePsets(test.bootstrap.IFC4):
psets.remove(shared_pset)
used_elements = set()
for pset in psets:
pset_elements = ifcopenshell.util.element.get_elements_using_pset(pset)
pset_elements = ifcopenshell.util.element.get_elements_by_pset(pset)
assert len(pset_elements) == 1
used_elements.update(pset_elements)
assert used_elements == set(elements)
# Leave shared pset untouched as it's not part of the provided query.
assert ifcopenshell.util.element.get_elements_using_pset(shared_pset) == set(shared_pset_elements)
assert ifcopenshell.util.element.get_elements_by_pset(shared_pset) == set(shared_pset_elements)
class TestUnsharePsetsIFC2X3(test.bootstrap.IFC2X3, TestUnsharePsets):