Fix terrible bug #1819 where duplicating mapped elements didn't actually copy the geometry mapping.

src/ifcopenshell-python/ifcopenshell/api/type/assign_type.py

@@ -54,8 +54,14 @@ class Usecase:
                 }
             )
 
-        self.map_representations()
+        ifcopenshell.api.run(
+            "type.map_type_representations",
+            self.file,
+            related_object=self.settings["related_object"],
+            relating_type=self.settings["relating_type"],
+        )
         self.map_material_usages()
+        return types
 
     def map_representations(self):
         if not self.settings["relating_type"].RepresentationMaps:

src/ifcopenshell-python/ifcopenshell/api/type/map_type_representations.py

@@ -0,0 +1,41 @@
+import ifcopenshell
+import ifcopenshell.api
+import ifcopenshell.util.element
+
+
+class Usecase:
+    def __init__(self, file, **settings):
+        self.file = file
+        self.settings = {
+            "related_object": None,
+            "relating_type": None,
+        }
+        for key, value in settings.items():
+            self.settings[key] = value
+
+    def execute(self):
+        if not self.settings["relating_type"].RepresentationMaps:
+            return
+        representations = []
+        if self.settings["related_object"].Representation:
+            representations = self.settings["related_object"].Representation.Representations
+        for representation in representations:
+            print('for each rep', representation)
+            ifcopenshell.api.run(
+                "geometry.unassign_representation",
+                self.file,
+                product=self.settings["related_object"],
+                representation=representation,
+            )
+            ifcopenshell.api.run("geometry.remove_representation", self.file, **{"representation": representation})
+        for representation_map in self.settings["relating_type"].RepresentationMaps:
+            representation = representation_map.MappedRepresentation
+            mapped_representation = ifcopenshell.api.run(
+                "geometry.map_representation", self.file, representation=representation
+            )
+            ifcopenshell.api.run(
+                "geometry.assign_representation",
+                self.file,
+                product=self.settings["related_object"],
+                representation=mapped_representation,
+            )

src/ifcopenshell-python/test/api/type/test_map_type_representation.py

@@ -0,0 +1,33 @@
+import test.bootstrap
+import ifcopenshell.api
+
+
+class TestMapTypeRepresentations(test.bootstrap.IFC4):
+    def test_doing_nothing_if_the_type_has_no_representation_maps(self):
+        element = self.file.createIfcWall()
+        type = self.file.createIfcWallType()
+        ifcopenshell.api.run("type.assign_type", self.file, related_object=element, relating_type=type)
+        total_elements = len([e for e in self.file])
+        ifcopenshell.api.run("type.map_type_representations", self.file, related_object=element, relating_type=type)
+        assert len([e for e in self.file]) == total_elements
+
+    def test_removing_existing_element_representations_and_mapping_type_representations(self):
+        context = self.file.createIfcGeometricRepresentationSubContext()
+        element = self.file.createIfcWall(
+            Representation=self.file.createIfcProductRepresentation(
+                Representations=[self.file.createIfcShapeRepresentation(ContextOfItems=context)]
+            )
+        )
+        type = self.file.createIfcWallType(
+            RepresentationMaps=[
+                self.file.createIfcRepresentationMap(
+                    MappedRepresentation=self.file.createIfcShapeRepresentation(ContextOfItems=context)
+                )
+            ]
+        )
+        self.file.createIfcRelDefinesByType(RelatingType=type, RelatedObjects=[element])
+        ifcopenshell.api.run("type.map_type_representations", self.file, related_object=element, relating_type=type)
+        rep = element.Representation.Representations[0]
+        assert rep.RepresentationType == "MappedRepresentation"
+        assert rep.Items[0].MappingSource == type.RepresentationMaps[0]
+        assert len(self.file.by_type("IfcShapeRepresentation")) == 2