Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-19 22:50:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

ifcviewer: promote runtime perf knobs, drop always-on settings

Browse Source 
Promotes five env-var-driven knobs to AppSettings + the settings dialog
(min pixel radius, motion min pixel radius, LOD1 pixel threshold, HiZ
resolution, HiZ on/off).  Defaults: motion min pixel radius is now 10
(was 0/disabled) and IFC_HIZ_MOTION is on by default — the strict
view-projection gate reverts via env var =0 when chasing HiZ
correctness bugs.  ViewportWindow connects each *Changed signal so
changes invalidate cached cull state and take effect on the next
frame.

Removes "Load Property Data Source" and "Apply Coordinate Operation"
from the settings dialog: both are now hardcoded on.  The basic-info
property fallback (used when there's no live IFC source for an object,
e.g. .ifcview without a sibling) now triggers organically when
ElementRegistry::findEntity returns null instead of being gated on a
user toggle.  Federation::guessFederatedFalseOrigin lost its
apply_coordinate_operation parameter and now uses
georef.has_coordinate_operation directly.

src/ifcviewer/settings.rst documents the remaining diagnostic env vars
(IFC_HIZ_MOTION, IFC_CULL_THREADS, IFC_SKIP_MDI, IFC_MAX_SUBDRAWS,
IFC_FPS_HITCH_MS, IFC_SUBDRAW_DIAG, IFC_LOD_*) plus a cross-walk from
the old promoted-knob env-var names to their new QSettings keys.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
Dion Moult
2026-05-10 19:37:20 +10:00
parent 0a297babea
commit a900f2c437
14 changed files with 324 additions and 185 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcviewer/Federation.h
+7 -8
View File
@@ -135,18 +135,17 @@ ModelGeoref computeModelGeoref(ifcopenshell::file* ifc_file);
// Position: `first_placement_meters` is the model's "anchor" placement —
// typically the first instance's `placement_transformation`, which the
// iterator already produces in metres (its `convert-back-units` default
// is false). The translation is optionally lifted through
// `georef.coordinate_operation_meters` (controlled by
// `apply_coordinate_operation`), then expressed in the federation unit.
// is false). The translation is lifted through
// `georef.coordinate_operation_meters` when one is present, then
// expressed in the federation unit.
//
// Rotation: read directly from `georef.coordinate_operation_meters` when
// `apply_coordinate_operation && has_coordinate_operation` (this is the
// helmert grid-north angle). Otherwise zero. Anticlockwise positive.
// Rotation: read directly from `georef.coordinate_operation_meters`
// when `has_coordinate_operation` (this is the helmert grid-north
// angle); otherwise zero. Anticlockwise positive.
FederatedFalseOrigin
guessFederatedFalseOrigin(const Eigen::Matrix4d& first_placement_meters,
const ModelGeoref& georef,
const FederationConfig& fed_cfg,
bool apply_coordinate_operation);
const FederationConfig& fed_cfg);
// 1 federation_unit -> N metres.
double federationUnitToMeters(const FederationConfig&);