From aaa763ad21b86624952ec49c70be0602b5a7896b Mon Sep 17 00:00:00 2001 From: Andrej730 Date: Mon, 3 Aug 2026 12:22:31 +0500 Subject: [PATCH] Drop revenants from previously used linters --- src/bcf/bcf/geometry.py | 2 +- src/bcf/bcf/v3/bcfapi.py | 4 +- src/bcf/pyproject.toml | 80 +------------------ src/bcf/requirements-dev.txt | 6 -- src/bonsai/Makefile | 5 -- src/bonsai/bonsai/core/tool.py | 1 - src/bonsai/scripts/generate_au_library.py | 1 - .../generate_steel_profiles_library.py | 1 - src/ifcopenshell-python/Makefile | 5 -- 9 files changed, 4 insertions(+), 101 deletions(-) delete mode 100644 src/bcf/requirements-dev.txt diff --git a/src/bcf/bcf/geometry.py b/src/bcf/bcf/geometry.py index b8969d4837..e199840367 100644 --- a/src/bcf/bcf/geometry.py +++ b/src/bcf/bcf/geometry.py @@ -35,7 +35,7 @@ def camera_vectors_from_target_position( """ camera_offset = np.array((5, 5, 5)) if offset is None else offset camera_position = target_position + camera_offset - camera_direction = unit_vector(-camera_offset) # pylint: disable=invalid-unary-operand-type + camera_direction = unit_vector(-camera_offset) camera_right = unit_vector(np.cross(np.array([0.0, 0.0, 1.0]), camera_direction)) camera_up = unit_vector(np.cross(camera_direction, camera_right)) return camera_position.tolist(), camera_direction.tolist(), camera_up.tolist() diff --git a/src/bcf/bcf/v3/bcfapi.py b/src/bcf/bcf/v3/bcfapi.py index 515b2f2fe2..5d47ac6fe1 100644 --- a/src/bcf/bcf/v3/bcfapi.py +++ b/src/bcf/bcf/v3/bcfapi.py @@ -96,10 +96,10 @@ class FoundationClient: webbrowser.open(f"{auth_endpoint}?{query}") server.timeout = 100 server.handle_request() - if server.auth_code and server.auth_state == state: # pylint: disable=E1101 + if server.auth_code and server.auth_state == state: data = { "grant_type": "authorization_code", - "code": server.auth_code, # pylint: disable=E1101 type:ignore + "code": server.auth_code, "redirect_uri": f"http://localhost:{server.server_address[1]}/{self.redirect_subdir}", } headers = self._get_access_token_headers() diff --git a/src/bcf/pyproject.toml b/src/bcf/pyproject.toml index b4e990f39c..449f3cd1f5 100644 --- a/src/bcf/pyproject.toml +++ b/src/bcf/pyproject.toml @@ -31,14 +31,6 @@ classifiers = [ Source = "https://github.com/IfcOpenShell/IfcOpenShell" Issues = "https://github.com/IfcOpenShell/IfcOpenShell/issues" -[tool.black] -line-length = 120 -extend-exclude = "model" - -[tool.isort] -profile = "black" -extend_skip_glob = ["src/bcf/*/model/*"] - [tool.coverage.paths] source = ["src"] @@ -60,7 +52,7 @@ exclude_lines = [ [tool.tox] legacy_tox_ini = """ [tox] -env_list = lint, type, py3{10,11} +env_list = py3{10,11} skip_missing_interpreters = true [testenv] @@ -69,78 +61,8 @@ deps = pytest-cov coverage commands = pytest --cov --cov-report=term tests - -[testenv:lint] -description = run linters -skip_install = true -deps = - black - isort - pylint -commands = - black {posargs:.} - isort {posargs:.} - pylint {posargs:.} --output-format=colorized - -[testenv:type] -description = run type checks -deps = - mypy>=0.991 -commands = - - mypy {posargs:src} """ -[tool.mypy] -check_untyped_defs = true -disallow_any_generics = true -disallow_incomplete_defs = true -disallow_subclassing_any = true -disallow_untyped_calls = true -disallow_untyped_defs = true -no_implicit_optional = true -#no_implicit_reexport = true -show_column_numbers = true -show_error_codes = true -show_error_context = true -strict_equality = true -strict_optional = true -warn_redundant_casts = true -#warn_return_any = true -warn_unreachable = true -warn_unused_configs = true -warn_unused_ignores = true -exclude= "src/bcf/v(2|3)/model" -plugins = "numpy.typing.mypy_plugin" - -[[tool.mypy.overrides]] -module = "tests" -disallow_untyped_decorators = false -disallow_untyped_defs = false - -[[tool.mypy.overrides]] -module = [ - "pytest", - "pytest_mock", - "ifcopenshell", - "ifcopenshell.*", -] -ignore_missing_imports = true - -[tool.pylint.main] -ignore = ["model"] -ignored-modules = ["bcf.v2.model", "bcf.v3.model", "xsdata"] -jobs = 0 -disable="all" -enable="E" # B,B9,BLK,C,D,E,F,I,N,S,W - -[tool.pylint.design] -max-args = 10 -max-attributes = 10 - -[tool.pylint.format] -expected-line-ending-format = "LF" -max-line-length = 120 - [tool.ruff] extend = "../../pyproject.toml" lint.select = [ diff --git a/src/bcf/requirements-dev.txt b/src/bcf/requirements-dev.txt deleted file mode 100644 index 9169ee6a0c..0000000000 --- a/src/bcf/requirements-dev.txt +++ /dev/null @@ -1,6 +0,0 @@ -black -mypy -pylint -isort -xsdata -tox==3.27.1 diff --git a/src/bonsai/Makefile b/src/bonsai/Makefile index c3324178df..6708457baa 100644 --- a/src/bonsai/Makefile +++ b/src/bonsai/Makefile @@ -370,11 +370,6 @@ test-modal: test-reregister: blender --python scripts/reregister_bonsai.py -.PHONY: qa -qa: - black . - pylint ./* --output-format=colorized --disable all --enable E --disable import-error - .PHONY: coverage coverage: coverage run --source bonsai.core -m pytest -p no:pytest-blender test/core diff --git a/src/bonsai/bonsai/core/tool.py b/src/bonsai/bonsai/core/tool.py index 986444c314..6280e78309 100644 --- a/src/bonsai/bonsai/core/tool.py +++ b/src/bonsai/bonsai/core/tool.py @@ -21,7 +21,6 @@ import inspect from typing import Optional # fmt: off -# pylint: skip-file # This interface class and decorator is magic syntactic sugar to allow concise interface definitions # If we didn't do this, Python is unnecessarily verbose, which I find distracting. Don't black this file :) diff --git a/src/bonsai/scripts/generate_au_library.py b/src/bonsai/scripts/generate_au_library.py index 91fe224255..1d62f8dd00 100644 --- a/src/bonsai/scripts/generate_au_library.py +++ b/src/bonsai/scripts/generate_au_library.py @@ -17,7 +17,6 @@ # along with Bonsai. If not, see . # fmt: off -# pylint: skip-file import bpy import ifcopenshell.api diff --git a/src/bonsai/scripts/generate_steel_profiles_library.py b/src/bonsai/scripts/generate_steel_profiles_library.py index 7db5135686..403f67f7fc 100644 --- a/src/bonsai/scripts/generate_steel_profiles_library.py +++ b/src/bonsai/scripts/generate_steel_profiles_library.py @@ -17,7 +17,6 @@ # along with Bonsai. If not, see . # fmt: off -# pylint: skip-file from math import pi from pathlib import Path diff --git a/src/ifcopenshell-python/Makefile b/src/ifcopenshell-python/Makefile index 16ee80a884..ae999f272c 100644 --- a/src/ifcopenshell-python/Makefile +++ b/src/ifcopenshell-python/Makefile @@ -80,11 +80,6 @@ test-mathutils: pytest -p no:pytest-blender test/util/test_shape_builder.py -.PHONY: qa -qa: - black . - pylint ./* --output-format=colorized --disable all --enable E - .PHONY: license license: #copyright-header --license LGPL3 --copyright-holder "Thomas Krijnen " --copyright-year "2022" --copyright-software "IfcOpenShell" --copyright-software-description "IFC toolkit and geometry engine" -a ./ -o ./