Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-25 17:57:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix adding transom to door #6230 (d23cfcb)

Browse Source
This commit is contained in:
Andrej730
2025-02-25 18:13:02 +05:00
parent f63d6b80c5
commit aaf008f007
2 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcopenshell-python/ifcopenshell/api/geometry/add_door_representation.py
+4 -1
View File
@@ -622,7 +622,7 @@ class Usecase:
window_lining_size = V(overall_width, lining_depth, window_lining_height) window_lining_size = V(overall_width, lining_depth, window_lining_height)
window_position = V(0, 0, overall_height - window_lining_height) window_position = V(0, 0, overall_height - window_lining_height)
frame_size = V(door_opening_width, frame_depth, frame_height) frame_size = V(door_opening_width, frame_depth, frame_height)
window_lining_items, frame_items, glass_items = create_ifc_window( current_window_items = create_ifc_window(
builder, builder,
window_lining_size, window_lining_size,
window_lining_thickness, window_lining_thickness,
@@ -633,6 +633,9 @@ class Usecase:
glass_thickness, glass_thickness,
window_position, window_position,
) )
window_lining_items = current_window_items["Lining"]
frame_items = current_window_items["Framing"]
glass_items = current_window_items["Glazing"]
lining_offset_items = lining_items + door_items + window_lining_items + frame_items + glass_items lining_offset_items = lining_items + door_items + window_lining_items + frame_items + glass_items
builder.translate(lining_offset_items, (0, lining_offset, 0)) builder.translate(lining_offset_items, (0, lining_offset, 0))
src/ifcopenshell-python/ifcopenshell/api/geometry/add_window_representation.py
+1 -1
View File
@@ -181,7 +181,7 @@ def create_ifc_window(
glass_thickness: float, glass_thickness: float,
position: np.ndarray, position: np.ndarray,
x_offsets: Optional[list[float]] = None, x_offsets: Optional[list[float]] = None,
) -> tuple[list[ifcopenshell.entity_instance], list[ifcopenshell.entity_instance], list[ifcopenshell.entity_instance]]: ) -> dict[str, list[ifcopenshell.entity_instance]]:
"""`lining_thickness` and `x_offsets` are expected to be defined as a list, """`lining_thickness` and `x_offsets` are expected to be defined as a list,
similarly to `create_ifc_window_frame_simple` `thickness` argument""" similarly to `create_ifc_window_frame_simple` `thickness` argument"""
lining_items: list[ifcopenshell.entity_instance] = [] lining_items: list[ifcopenshell.entity_instance] = []