From ac3ee016e7f041bdb11bb109d627ee8c7ab68550 Mon Sep 17 00:00:00 2001 From: Andrej730 Date: Fri, 28 Aug 2026 18:42:07 +0500 Subject: [PATCH] build-all: fix `LIBRARY_EXT` not considering macos Led to error during OpenCOLLADA build: ``` 2026-08-28 13:33:34,391 make[2]: *** No rule to make target `/Users/runner/work/IfcOpenShell/IfcOpenShell/build/Darwin/arm64/10.15/install/pcre-shared-8.41/lib/libpcre.so', needed by `lib/libOpenCOLLADABaseUtils.dylib'. Stop. 2026-08-28 13:33:34,391 make[2]: *** Waiting for unfinished jobs.... ``` --- nix/build-all.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nix/build-all.py b/nix/build-all.py index d9a67bd99e..7e7791cc64 100644 --- a/nix/build-all.py +++ b/nix/build-all.py @@ -532,7 +532,7 @@ BUILD_STATIC = not ARGS.shared ENABLE_FLAG = "--enable-static" if BUILD_STATIC else "--enable-shared" DISABLE_FLAG = "--disable-shared" if BUILD_STATIC else "--disable-static" LINK_TYPE = "static" if BUILD_STATIC else "shared" -LIBRARY_EXT = "a" if BUILD_STATIC else "so" +LIBRARY_EXT = "a" if BUILD_STATIC else ("dylib" if APPLE else "so") PIC = "-fPIC" if BUILD_STATIC else "" if DYNAMIC_ARGS.py_versions: