New assign / unassign declaration usecase, minor code & formatting cleanup

src/ifcopenshell-python/ifcopenshell/api/sequence/add_work_schedule.py

@@ -6,7 +6,12 @@ from datetime import datetime
 class Usecase:
     def __init__(self, file, **settings):
         self.file = file
-        self.settings = {"name": "Unnamed", "predefined_type": "NOTDEFINED", "start_time": datetime.now(), "work_plan":None}
+        self.settings = {
+            "name": "Unnamed",
+            "predefined_type": "NOTDEFINED",
+            "start_time": datetime.now(),
+            "work_plan": None,
+        }
         for key, value in settings.items():
             self.settings[key] = value
 
@@ -23,25 +28,18 @@ class Usecase:
         if person:
             work_schedule.Creators = [person]
         work_schedule.StartTime = ifcopenshell.util.date.datetime2ifc(self.settings["start_time"], "IfcDateTime")
-        
-        if self.settings["work_plan"]:
-            rel_aggregates = ifcopenshell.api.run("aggregate.assign_object", self.file, **{
-                "product": work_schedule,
-                "relating_object": self.settings["work_plan"]
-            })
-        else:
-            context = self.file.by_type("IfcContext")[0]
-            if context.Declares:
-                rel_declares = context.Declares[0]
-                ifcopenshell.api.run("owner.update_owner_history", self.file, element=rel_declares)
-            else:
-                rel_declares = self.file.create_entity("IfcRelDeclares", **{
-                    "GlobalId": ifcopenshell.guid.new(),
-                    "OwnerHistory": ifcopenshell.api.run("owner.create_owner_history", self.file),
-                    "RelatingContext": context
-                })
-            related_definitions = list(rel_declares.RelatedDefinitions or [])
-            related_definitions.append(work_schedule)
-            rel_declares.RelatedDefinitions = related_definitions
 
-        return work_schedule
+        if self.settings["work_plan"]:
+            ifcopenshell.api.run(
+                "aggregate.assign_object",
+                self.file,
+                **{"product": work_schedule, "relating_object": self.settings["work_plan"]}
+            )
+        else:
+            # TODO: this is an ambiguity by buildingSMART
+            # See https://forums.buildingsmart.org/t/is-the-ifcworkschedule-project-declaration-mutually-exclusive-to-aggregation-within-a-relating-ifcworkplan/3510
+            context = self.file.by_type("IfcContext")[0]
+            ifcopenshell.api.run(
+                "project.assign_declaration", self.file, definition=work_schedule, relating_context=context
+            )
+        return work_schedule