From aef38bd869d5b2641902412841afc47d8c76e1e5 Mon Sep 17 00:00:00 2001
From: Thomas Krijnen <t.krijnen@gmail.com>
Date: Wed, 4 Dec 2024 10:39:01 +0100
Subject: [PATCH] Fix matrix access in XmlSerializer #5840

---
 src/serializers/schema_dependent/XmlSerializer.cpp | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/serializers/schema_dependent/XmlSerializer.cpp b/src/serializers/schema_dependent/XmlSerializer.cpp
index 43cac574c2..3aefa71d7a 100644
--- a/src/serializers/schema_dependent/XmlSerializer.cpp
+++ b/src/serializers/schema_dependent/XmlSerializer.cpp
@@ -130,12 +130,11 @@ boost::optional<std::string> format_attribute(ifcopenshell::geometry::abstract_m
 				auto matrix = ifcopenshell::geometry::taxonomy::cast< ifcopenshell::geometry::taxonomy::matrix4>(item);
 				
 				std::stringstream stream;
-				for (int i = 1; i < 5; ++i) {
-					for (int j = 1; j < 4; ++j) {
+				for (int i = 0; i < 4; ++i) {
+					for (int j = 0; j < 4; ++j) {
 						const double trsf_value = matrix->ccomponents()(j, i);
 						stream << std::setprecision (std::numeric_limits< double >::max_digits10) << trsf_value << " ";
 					}
-					stream << ((i == 4) ? "1" : "0 ");
 				}
 				value = stream.str();