Fix tests missing assert statement - add assert and fix them

This commit is contained in:
Andrej730
2025-05-15 10:40:46 +05:00
parent 292aca6685
commit b20997dea8
3 changed files with 4 additions and 3 deletions
+1
View File
@@ -682,6 +682,7 @@ class Drawing(bonsai.core.tool.Drawing):
@classmethod @classmethod
def generate_sheet_identification(cls) -> str: def generate_sheet_identification(cls) -> str:
number = len([d for d in tool.Ifc.get().by_type("IfcDocumentInformation") if d.Scope == "SHEET"]) number = len([d for d in tool.Ifc.get().by_type("IfcDocumentInformation") if d.Scope == "SHEET"])
number += 1
return "A" + str(number).zfill(2) return "A" + str(number).zfill(2)
@classmethod @classmethod
+2 -2
View File
@@ -478,9 +478,9 @@ class TestGenerateSheetIdentification(NewFile):
def test_run(self): def test_run(self):
ifc = ifcopenshell.file() ifc = ifcopenshell.file()
tool.Ifc.set(ifc) tool.Ifc.set(ifc)
subject.generate_sheet_identification() == "A01" assert subject.generate_sheet_identification() == "A01"
document = ifc.createIfcDocumentInformation() document = ifc.createIfcDocumentInformation()
subject.generate_sheet_identification() == "A02" assert subject.generate_sheet_identification() == "A02"
class TestGetTextLiteral(NewFile): class TestGetTextLiteral(NewFile):
+1 -1
View File
@@ -164,7 +164,7 @@ class TestGetPorts(NewFile):
element = ifc.createIfcDuctSegment() element = ifc.createIfcDuctSegment()
port = ifc.createIfcDistributionPort() port = ifc.createIfcDistributionPort()
ifcopenshell.api.run("system.assign_port", ifc, element=element, port=port) ifcopenshell.api.run("system.assign_port", ifc, element=element, port=port)
subject.get_ports(element) == [port] assert subject.get_ports(element) == [port]
class TestImportSystemAttributes(NewFile): class TestImportSystemAttributes(NewFile):