Door modifier - basic setup

Also: - refactored window modifier code - part of it is now reused building a door and can be used by other module in the future - fixed bug with window lining intersecting frame when lining_depth < panel_depth - simplified the way lining is built in ifc - previously it was using 4-6 extrusions, now it's 1-2 which is also better for 2D drawings
2026-08-09 17:31:45 +00:00 · 2023-01-31 15:10:37 +05:00
parent a8400ec963
commit b2bdbdd8c3
8 changed files with 1251 additions and 220 deletions
@@ -0,0 +1,297 @@
+# IfcOpenShell - IFC toolkit and geometry engine
+# Copyright (C) 2023 @Andrej730
+#
+# This file is part of IfcOpenShell.
+#
+# IfcOpenShell is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Lesser General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# IfcOpenShell is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU Lesser General Public License for more details.
+#
+# You should have received a copy of the GNU Lesser General Public License
+# along with IfcOpenShell.  If not, see <http://www.gnu.org/licenses/>.
+
+import ifcopenshell.util.unit
+from ifcopenshell.util.shape_builder import ShapeBuilder, V
+from ifcopenshell.api.geometry.add_window_representation import create_ifc_window
+from mathutils import Vector
+
+import collections
+
+
+def create_ifc_door_lining_items(builder: ShapeBuilder, size: Vector, thickness: Vector, position:Vector=V(0,0,0).freeze()):
+    """`thickness` of the profile is defined as list in the following order: `(SIDE, TOP)`
+
+    `thickness` can be also defined just as 1 float value.
+    """
+    if not isinstance(thickness, collections.abc.Iterable):
+        thickness = [thickness] * 2
+
+    th_side, th_up = thickness
+
+    left_lining = builder.rectangle(V(th_side, 0, size.z))
+    right_lining = builder.translate(left_lining, V(size.x-th_side, 0, 0), create_copy=True)
+    top_lining = builder.rectangle(V(size.x, 0, th_up), V(0, 0, size.z-th_up))
+    items = [left_lining, right_lining, top_lining]
+
+    items = [builder.extrude(l, size.y, extrusion_vector=V(0,1,0)) for l in items]
+    builder.translate(items, position)
+
+    return items
+
+def create_ifc_box(builder: ShapeBuilder, size: Vector, position:Vector=V(0,0,0).freeze()):
+    rect = builder.rectangle(size.xy)
+    box = builder.extrude(rect, size.z, position=position, extrusion_vector=V(0,0,1))
+    return box
+
+
+class Usecase:
+    def __init__(self, file, **settings):
+        """units in settings expected to be in ifc project units"""
+        self.file = file
+        # http://ifc43-docs.standards.buildingsmart.org/IFC/RELEASE/IFC4x3/HTML/lexical/IfcDoor.htm
+        # http://ifc43-docs.standards.buildingsmart.org/IFC/RELEASE/IFC4x3/HTML/lexical/IfcDoorTypeOperationEnum.htm
+        # http://ifc43-docs.standards.buildingsmart.org/IFC/RELEASE/IFC4x3/HTML/lexical/IfcDoorLiningProperties.htm
+        # http://ifc43-docs.standards.buildingsmart.org/IFC/RELEASE/IFC4x3/HTML/lexical/IfcDoorPanelProperties.htm
+        self.settings = {"unit_scale": ifcopenshell.util.unit.calculate_unit_scale(self.file)}
+        # TODO: remove upper window from default props after tests
+        # TODO: check default values with blender props
+        self.settings.update(
+            {
+                "context": None,  # IfcGeometricRepresentationContext
+                "overall_height": self.convert_si_to_unit(0.9),
+                "overall_width": self.convert_si_to_unit(0.6),
+
+                # DOUBLE_DOOR_DOUBLE_SWING, DOUBLE_DOOR_FOLDING, DOUBLE_DOOR_LIFTING_VERTICAL, 
+                # DOUBLE_DOOR_SINGLE_SWING, DOUBLE_DOOR_SINGLE_SWING_OPPOSITE_LEFT, 
+                # DOUBLE_DOOR_SINGLE_SWING_OPPOSITE_RIGHT, DOUBLE_DOOR_SLIDING, 
+                # DOUBLE_SWING_LEFT, DOUBLE_SWING_RIGHT, FOLDING_TO_LEFT, 
+                # FOLDING_TO_RIGHT, LIFTING_HORIZONTAL, LIFTING_VERTICAL_LEFT, 
+                # LIFTING_VERTICAL_RIGHT, REVOLVING, REVOLVING_VERTICAL, 
+                # ROLLINGUP, SINGLE_SWING_LEFT, SINGLE_SWING_RIGHT, SLIDING_TO_LEFT, 
+                # SLIDING_TO_RIGHT, SWING_FIXED_LEFT, SWING_FIXED_RIGHT
+                # TODO: take into account door types
+                "operation_type": "SINGLE_SWING_LEFT", # door type
+                "lining_properties": {
+                    "LiningDepth": self.convert_si_to_unit(0.050),
+                    "LiningThickness": self.convert_si_to_unit(0.050),
+
+                    # offset from the outer side of the wall (by Y-axis)
+                    "LiningOffset": self.convert_si_to_unit(0.050),
+                    # offset from the wall
+                    "LiningToPanelOffsetX": self.convert_si_to_unit(0.025), 
+                    # offset from the elevation view rectangle (unlike windows)
+                    "LiningToPanelOffsetY": self.convert_si_to_unit(0.025),
+
+                    # Casing cover wall faces around the opening
+                    # on the left, right and upper sides
+                    # Casing should be either on both sides of the wall or no casing
+                    # If `LiningOffset` is present then therefore casing is not possible on outer wall
+                    # therefore there will be no casing on inner wall either 
+                    "CasingDepth": self.convert_si_to_unit(0.025), 
+                    "CasingThickness": self.convert_si_to_unit(0.075), # by Z-axis
+
+                    # TODO: link to wall thickness?
+                    # Threshold covers the bottom side of the opening
+                    "ThresholdDepth": self.convert_si_to_unit(0.025), 
+                    "ThresholdThickness": self.convert_si_to_unit(0.025), # by Z-axis
+                    # offset to X-axis
+                    # TODO: offset goes by Z-axis?
+                    "ThresholdOffset": self.convert_si_to_unit(0.025), 
+
+                    # transom - vertical distance between door and window panels 
+                    "TransomThickness": self.convert_si_to_unit(0.050),
+                    # TransomOffset - distance from the bottom door opening
+                    # to the beginning of the transom
+                    # unlike windows TransomOffset which goes to the center of the transom
+                    "TransomOffset": self.convert_si_to_unit(0.6),
+                    "ShapeAspectStyle": None,  # DEPRECATED
+                },
+                "panel_properties": {
+                    "PanelDepth": self.convert_si_to_unit(0.030),  # by Y
+                    "PanelWidth": 1.0,  # as ratio to the clear door opening
+                    "FrameDepth": self.convert_si_to_unit(0.035),  # by Y
+                    "FrameThickness": self.convert_si_to_unit(0.035),  # by X
+                    # LEFT, MIDDLE, RIGHT, NOTDEFINED
+                    "PanelPosition": ...,  # NEVER USED
+                    # defines the basic ways to describe how door panels operate
+                    # basically how it opens
+                    "PanelOperation": None,  # NEVER USED
+                    "ShapeAspectStyle": None,  # DEPRECATED
+                },
+            }
+        )
+
+        for key, value in settings.items():
+            self.settings[key] = value
+
+    def execute(self):
+        builder = ShapeBuilder(self.file)
+        overall_height = self.settings["overall_height"]
+        overall_width = self.settings["overall_width"]
+
+        # TODO: elevation view representation
+        if self.settings["context"].TargetView == "ELEVATION_VIEW":
+            rect = builder.rectangle(V(overall_width, 0, overall_height))
+            representation_evelevation = builder.get_representation(self.settings["context"], rect)
+            return representation_evelevation
+        
+        # TODO: implement 2d representation
+
+        panel_props = self.settings["panel_properties"]
+        lining_props = self.settings["lining_properties"]
+
+        # lining params
+        lining_depth = lining_props['LiningDepth']
+        lining_thickness_default = lining_props['LiningThickness']
+        lining_offset = lining_props['LiningOffset']
+        lining_to_panel_offset_x = lining_props['LiningToPanelOffsetX']
+        lining_to_panel_offset_y_full = lining_props['LiningToPanelOffsetY']
+
+        transom_thickness = lining_props['TransomThickness'] / 2
+        transfom_offset = lining_props['TransomOffset']
+        if transom_thickness == 0:
+            transfom_offset = 0
+
+        window_lining_height = overall_height - transfom_offset - transom_thickness
+        top_lining_thickness = transom_thickness or lining_thickness_default
+        panel_lining_overlap_x = max(lining_thickness_default - lining_to_panel_offset_x, 0) 
+        panel_top_lining_overlap_x = max(top_lining_thickness - lining_to_panel_offset_x, 0) 
+        door_opening_width = (overall_width - lining_to_panel_offset_x * 2)
+
+        threshold_thickness = lining_props['ThresholdThickness']
+        threshold_depth = lining_props['ThresholdDepth']
+        threshold_offset = lining_props['ThresholdOffset']
+        threshold_width = overall_width - lining_thickness_default * 2
+
+        casing_thickness = lining_props['CasingThickness']
+        casing_depth = lining_props['CasingDepth']
+
+        # panel params
+        panel_depth = panel_props['PanelDepth']
+        panel_width = door_opening_width * panel_props['PanelWidth']
+        frame_depth = panel_props['FrameDepth']
+        frame_thickness = panel_props['FrameThickness']
+        frame_height = window_lining_height - lining_to_panel_offset_x * 2
+        glass_thickness = self.convert_si_to_unit(0.01)
+
+        if transfom_offset:
+            panel_height = transfom_offset + transom_thickness - lining_to_panel_offset_x - threshold_thickness
+            lining_height = transfom_offset + transom_thickness
+        else:
+            panel_height = overall_height - lining_to_panel_offset_x - threshold_thickness
+            lining_height = overall_height
+        
+        # add lining
+        lining_size = V(overall_width, lining_depth, lining_height)
+        lining_thickness = [lining_thickness_default, top_lining_thickness]
+
+        lining_items = []
+        main_lining_size = lining_size
+        # need to check offsets to decide whether lining should be rectangle
+        # or L shaped
+        l_shape_check = lining_to_panel_offset_y_full < lining_size.y \
+                            and any(lining_to_panel_offset_x < th for th in lining_thickness)
+
+        if l_shape_check:
+            main_lining_size = lining_size.copy()
+            main_lining_size.y = lining_to_panel_offset_y_full
+
+            second_lining_size = lining_size.copy()
+            second_lining_size.y = lining_size.y - lining_to_panel_offset_y_full
+            second_lining_position = V(0, lining_to_panel_offset_y_full, 0)
+            second_lining_thickness = [min(th, lining_to_panel_offset_x) for th in lining_thickness]
+
+            second_lining = create_ifc_door_lining_items(builder, 
+                                                        second_lining_size, 
+                                                        second_lining_thickness, 
+                                                        second_lining_position)
+            lining_items.extend(second_lining)
+
+        main_lining = create_ifc_door_lining_items(builder, main_lining_size, lining_thickness)
+        lining_items.extend(main_lining)
+
+        # add threshold
+        if not threshold_thickness:
+            threshold_items = []
+        else:
+            threshold_size = V(threshold_width, threshold_depth, threshold_thickness)
+            threshold_position = V(lining_thickness_default, threshold_offset, 0)
+            threshold_items = [create_ifc_box(builder, threshold_size, threshold_position)]
+
+        # add casings
+        casing_items = []
+        if not lining_offset and casing_thickness:
+            casing_wall_overlap = max(casing_thickness - lining_thickness_default, 0)
+            casing_size = V(overall_width + casing_wall_overlap*2, casing_depth, overall_height+casing_wall_overlap)
+            casing_position = V(-casing_wall_overlap, -casing_depth, 0)
+            outer_casing_items = create_ifc_door_lining_items(builder, casing_size, casing_thickness, casing_position)
+            casing_items.extend(outer_casing_items)
+
+            inner_casing_thickness = [
+                casing_thickness-panel_lining_overlap_x, 
+                casing_thickness-panel_top_lining_overlap_x
+            ]
+            inner_casing_position = V(-casing_wall_overlap, lining_depth, 0)
+            inner_casing_items = create_ifc_door_lining_items(builder, casing_size, inner_casing_thickness, inner_casing_position)
+            casing_items.extend(inner_casing_items)
+
+        # add door panel
+        panel_size = V(
+            panel_width,
+            panel_depth,
+            panel_height
+        )
+        panel_position = V(
+            lining_to_panel_offset_x,
+            lining_to_panel_offset_y_full,
+            threshold_thickness
+        )
+        panel_items = [create_ifc_box(builder, panel_size, panel_position)]
+
+        # add on top window
+        if not transom_thickness:
+            window_lining_items = []
+            frame_items = []
+            glass_items = []
+        else:
+            window_lining_thickness = [lining_thickness_default] * 3        
+            window_lining_thickness.append(transom_thickness)
+            window_lining_size = V(
+                overall_width, 
+                lining_depth,
+                window_lining_height
+            )
+            window_position = V(0, 0, overall_height-window_lining_height)
+            frame_size = V(
+                door_opening_width,
+                frame_depth,
+                frame_height
+            )
+            window_lining_items, frame_items, glass_items = create_ifc_window(
+                builder, 
+                window_lining_size,
+                window_lining_thickness,
+                lining_to_panel_offset_x,
+                lining_to_panel_offset_y_full,
+                frame_size,
+                frame_thickness,
+                glass_thickness,
+                window_position
+            )
+
+        lining_offset_items = lining_items+panel_items+window_lining_items+frame_items+glass_items
+        builder.translate(lining_offset_items, V(0, lining_offset, 0))
+
+        ouput_items = lining_offset_items + threshold_items + casing_items
+        print(len(ouput_items), 'items ready')
+        representation = builder.get_representation(self.settings["context"], ouput_items)
+        return representation
+
+    def convert_si_to_unit(self, value):
+        return value / self.settings["unit_scale"]
@@ -1,5 +1,5 @@
 # IfcOpenShell - IFC toolkit and geometry engine
-# Copyright (C) 2022 @Andrej730
+# Copyright (C) 2023 @Andrej730
 #
 # This file is part of IfcOpenShell.
 #
@@ -17,9 +17,10 @@
 # along with IfcOpenShell.  If not, see <http://www.gnu.org/licenses/>.

 import ifcopenshell.util.unit
-from math import sin, cos
 from ifcopenshell.util.shape_builder import ShapeBuilder, V
+from itertools import chain
 from mathutils import Vector
+import collections


 # SCHEMAS describe panels setup
@@ -40,6 +41,95 @@ DEFAULT_PANEL_SCHEMAS = {
    "TRIPLE_PANEL_VERTICAL":   [[0, 1, 2]],
 }

+def create_ifc_window_frame_simple(
+    builder,
+    size: Vector, 
+    thickness: Vector, 
+    position: Vector = V(0,0,0)):
+    """`thickness` of the profile is defined as list in the following order: 
+    `(LEFT, TOP, RIGHT, BOTTOM)`
+
+    `thickness` can be also defined just as 1 float value.
+    """
+
+    if not isinstance(thickness, collections.abc.Iterable):
+        thickness = [thickness] * 4
+
+    th_left, th_up, th_right, th_bottom = thickness
+
+    panel_rect = builder.rectangle(size=size*V(1,0,1))
+
+    inner_rect_size = size - V(th_left+th_right, 0, th_bottom+th_up)
+    inner_rect = builder.rectangle(
+        size=inner_rect_size*V(1, 0, 1),
+        position=V(th_left, 0, th_bottom)
+    )
+
+    panel_profile = builder.profile(panel_rect, inner_curves=inner_rect)
+    panel_extruded = builder.extrude(
+        panel_profile, 
+        size.y, 
+        extrusion_vector=V(0, 1, 0), 
+        position=position
+    )
+    return panel_extruded
+
+def create_ifc_window(
+    builder,
+    lining_size: Vector,
+    lining_thickness,
+    lining_to_panel_offset_x,
+    lining_to_panel_offset_y_full,
+    frame_size,
+    frame_thickness,
+    glass_thickness,
+    position: Vector):
+
+    lining_items = []
+    main_lining_size = lining_size
+
+    # need to check offsets to decide whether lining should be rectangle
+    # or L shaped
+    l_shape_check = lining_to_panel_offset_y_full < lining_size.y \
+                        and any(lining_to_panel_offset_x < th for th in lining_thickness)
+
+    if l_shape_check:
+        main_lining_size = lining_size.copy()
+        main_lining_size.y = lining_to_panel_offset_y_full
+
+        second_lining_size = lining_size.copy()
+        second_lining_size.y = lining_size.y - lining_to_panel_offset_y_full
+        second_lining_position = V(0, lining_to_panel_offset_y_full, 0)
+        second_lining_thickness = [min(th, lining_to_panel_offset_x) for th in lining_thickness]
+
+        second_lining = create_ifc_window_frame_simple(builder, 
+                                                       second_lining_size, 
+                                                       second_lining_thickness, 
+                                                       second_lining_position)
+        lining_items.append(second_lining)
+
+    main_lining = create_ifc_window_frame_simple(builder, main_lining_size, lining_thickness)
+    lining_items.append(main_lining)
+
+    frame_position = V(
+        lining_to_panel_offset_x, 
+        lining_to_panel_offset_y_full, 
+        lining_to_panel_offset_x
+    )
+
+    frame_extruded = create_ifc_window_frame_simple(builder, frame_size, frame_thickness, frame_position)
+
+    glass_position = frame_position + V(0, frame_size.y / 2 - glass_thickness / 2, 0)
+    glass_rect = builder.deep_copy(frame_extruded.SweptArea.InnerCurves[0])
+    glass = builder.extrude(
+        glass_rect, glass_thickness, extrusion_vector=V(0, 1, 0), position=glass_position
+    )
+
+    output_items = [lining_items, [frame_extruded], [glass]]
+    builder.translate(chain(*output_items), position)
+
+    return output_items
+

 class Usecase:
    def __init__(self, file, **settings):
@@ -63,7 +153,10 @@ class Usecase:
                    "LiningDepth": self.convert_si_to_unit(0.050),
                    "LiningThickness": self.convert_si_to_unit(0.050),
                    "LiningOffset": self.convert_si_to_unit(0.050),  # offset to the wall
+                    # offset from the wall
                    "LiningToPanelOffsetX": self.convert_si_to_unit(0.025),
+                    # offset from the lining
+                    # full offset from Y axis = (lining_depth - frame_depth) + lining_to_panel_offset_y
                    "LiningToPanelOffsetY": self.convert_si_to_unit(0.025),
                    # applies to DoublePanelVertical, TriplePanelBottom, TriplePanelTop,
                    # TriplePanelLeft, TriplePanelRight
@@ -72,7 +165,7 @@ class Usecase:
                    # distance from the first lining to the mullion center
                    "FirstMullionOffset": self.convert_si_to_unit(0.3),
                    # applies to TriplePanelVertical
-                    # distance from the first lining to the second mullion
+                    # distance from the first lining to the second mullion center
                    "SecondMullionOffset": self.convert_si_to_unit(0.45),
                    # applies to DoublePanelHorizontal, TriplePanelBottom, TriplePanelTop,
                    # TriplePanelLeft, TriplePanelRight
@@ -118,19 +211,21 @@ class Usecase:
        built_panels = []
        window_items = []

-        lining_thickness = self.settings["lining_properties"]["LiningThickness"]
-        lining_depth = self.settings["lining_properties"]["LiningDepth"]
-        lining_offset = self.settings["lining_properties"]["LiningOffset"]
-        lining_panel_offset_x = self.settings["lining_properties"]["LiningToPanelOffsetX"]
-        lining_panel_offset_y = self.settings["lining_properties"]["LiningToPanelOffsetY"]
-        glass_thickness = self.convert_si_to_unit(0.01)

-        mullion_thickness = self.settings["lining_properties"]["MullionThickness"] / 2
-        first_mullion_offset = self.settings["lining_properties"]["FirstMullionOffset"]
-        second_mullion_offset = self.settings["lining_properties"]["SecondMullionOffset"]
-        transom_thickness = self.settings["lining_properties"]["TransomThickness"] / 2
-        first_transom_offset = self.settings["lining_properties"]["FirstTransomOffset"]
-        second_transom_offset = self.settings["lining_properties"]["SecondTransomOffset"]
+        lining_props = self.settings["lining_properties"]
+        lining_thickness = lining_props["LiningThickness"]
+        lining_depth = lining_props["LiningDepth"]
+        lining_offset = lining_props["LiningOffset"]
+        lining_to_panel_offset_x = lining_props["LiningToPanelOffsetX"]
+        lining_to_panel_offset_y = lining_props["LiningToPanelOffsetY"]
+
+        mullion_thickness = lining_props["MullionThickness"] / 2
+        first_mullion_offset = lining_props["FirstMullionOffset"]
+        second_mullion_offset = lining_props["SecondMullionOffset"]
+        transom_thickness = lining_props["TransomThickness"] / 2
+        first_transom_offset = lining_props["FirstTransomOffset"]
+        second_transom_offset = lining_props["SecondTransomOffset"]
+        glass_thickness = self.convert_si_to_unit(0.01)

        panel_schema = list(reversed(panel_schema))

@@ -146,193 +241,75 @@ class Usecase:
                # calculate current panel dimensions
                if unique_cols > 1:
                    if column_i == 0:
-                        panel_width = first_mullion_offset
+                        lining_width = first_mullion_offset
                    elif column_i == unique_cols - 1:
-                        panel_width = overall_width - accumulated_width
+                        lining_width = overall_width - accumulated_width
                    else:
-                        panel_width = second_mullion_offset - accumulated_width
+                        lining_width = second_mullion_offset - accumulated_width
                else:
-                    panel_width = overall_width
+                    lining_width = overall_width

                if unique_rows_in_col[column_i] > 1:
                    if row_i == 0:
-                        panel_height = first_transom_offset
+                        lining_height = first_transom_offset
                    elif row_i == unique_rows_in_col[column_i] - 1:
-                        panel_height = overall_height - accumulated_height[column_i]
+                        lining_height = overall_height - accumulated_height[column_i]
                    else:
-                        panel_height = second_transom_offset - accumulated_height[column_i]
+                        lining_height = second_transom_offset - accumulated_height[column_i]
                else:
-                    panel_height = overall_height
+                    lining_height = overall_height

                if panel_i in built_panels:
-                    accumulated_height[column_i] += panel_height
-                    accumulated_width += panel_width
+                    accumulated_height[column_i] += lining_height
+                    accumulated_width += lining_width
                    continue

                cur_panel = panels[panel_i]
-                panel_depth = cur_panel["FrameDepth"]
-                panel_thickness = cur_panel["FrameThickness"]
+                frame_depth = cur_panel["FrameDepth"]
+                frame_thickness = cur_panel["FrameThickness"]
                current_items = []

-                panel_actual_width = panel_width - lining_panel_offset_x * 2
-                panel_actual_height = panel_height - lining_panel_offset_x * 2
-
-                glass_width = panel_actual_width - panel_thickness * 2
-                glass_height = panel_actual_height - panel_thickness * 2
-
-                # build lining
-                # lining is calculated on panel level because
-                # panel depth is used
-                lining_items_vertical_left = []
-                lining_items = []
+                frame_width = lining_width - lining_to_panel_offset_x * 2
+                frame_height = lining_height - lining_to_panel_offset_x * 2

                # calculate lining thickness
-                # taking into account mullions and transoms
-                thickness = [lining_thickness] * 4
+                # lining is calculated on panel level because
+                # panel depth is used
+                # also taking into account mullions and transoms
+                window_lining_thickness = [lining_thickness] * 4
                # mullion thickness
                if unique_cols > 1:
                    if column_i != 0:
-                        thickness[0] = mullion_thickness  # left column
+                        window_lining_thickness[0] = mullion_thickness  # left column
                    if column_i != unique_cols - 1:
-                        thickness[2] = mullion_thickness  # right column
+                        window_lining_thickness[2] = mullion_thickness  # right column
                # transom thickness
                if unique_rows_in_col[column_i] > 1:
                    if row_i != 0:
-                        thickness[3] = transom_thickness  # bottom row
+                        window_lining_thickness[3] = transom_thickness  # bottom row
                    if row_i != unique_rows_in_col[column_i] - 1:
-                        thickness[1] = transom_thickness  # top row
+                        window_lining_thickness[1] = transom_thickness  # top row
+                window_lining_size = V(lining_width, lining_depth, lining_height)
+                frame_size = V(frame_width, frame_depth, frame_height)
+                window_panel_position = V(accumulated_width, 0, accumulated_height[column_i])

-                def get_lining_rectangle(current_lining_thickness):
-                    lining_rectangle = builder.rectangle(size=V(current_lining_thickness, lining_depth))
-                    return lining_rectangle
-
-                def get_lining_polyline(current_lining_thickness):
-                    # need to check offsets to decide whether lining should be rectangle
-                    # or L shaped
-                    if lining_panel_offset_x >= current_lining_thickness or lining_panel_offset_y >= lining_depth:
-                        lining_polyline = get_lining_rectangle(current_lining_thickness)
-                    else:
-                        lining_points = [
-                            V(0, 0),
-                            V(0, lining_depth),
-                            V(lining_panel_offset_x, lining_depth),
-                            V(lining_panel_offset_x, lining_depth - (panel_depth - lining_panel_offset_y)),
-                            V(current_lining_thickness, lining_depth - (panel_depth - lining_panel_offset_y)),
-                            V(current_lining_thickness, 0),
-                        ]
-                        lining_polyline = builder.polyline(lining_points, closed=True)
-                    return lining_polyline
-
-                def create_lining_vertical(current_lining_thickness):
-                    current_vertical_lining_items = []
-                    lining_vertical_polyline = get_lining_polyline(current_lining_thickness)
-                    lining_vertical_height = panel_height - lining_panel_offset_x * 2
-                    extrusion_position = V(0, 0, lining_panel_offset_x)
-                    lining_vertical_extruded = builder.extrude(
-                        lining_vertical_polyline, lining_vertical_height, position=extrusion_position
-                    )
-                    current_vertical_lining_items.append(lining_vertical_extruded)
-
-                    # if lining panel X offset is present
-                    # then we also need to add two more box shapes
-                    # to finish the lining after the panel ends
-                    if lining_panel_offset_x > 0:
-                        lining_vertical_addition = builder.extrude(
-                            get_lining_rectangle(current_lining_thickness), lining_panel_offset_x
-                        )
-
-                        current_vertical_lining_items.append(lining_vertical_addition)
-                        current_vertical_lining_items.append(
-                            builder.translate(
-                                lining_vertical_addition,
-                                V(0, 0, panel_height - lining_panel_offset_x),
-                                create_copy=True,
-                            )
-                        )
-
-                    return current_vertical_lining_items
-
-                # vertical lining
-                lining_items_vertical_left = create_lining_vertical(thickness[0])
-                lining_items_vertical_right = create_lining_vertical(thickness[2])
-                lining_items_vertical_right = builder.mirror(
-                    lining_items_vertical_right, mirror_point=V(panel_width / 2, 0), mirror_axes=V(1, 0)
+                # create window panel
+                current_window_items = create_ifc_window(
+                    builder, 
+                    window_lining_size,
+                    window_lining_thickness,
+                    lining_to_panel_offset_x,
+                    (lining_depth - frame_depth) + lining_to_panel_offset_y,
+                    frame_size,
+                    frame_thickness,
+                    glass_thickness,
+                    window_panel_position
                )
-                lining_items.extend(lining_items_vertical_left)
-                lining_items.extend(lining_items_vertical_right)
-
-                # horizontal lining
-                def create_horizontal_lining(current_lining_thickness, mirror_point=None):
-                    lining_horizontal_polyline = get_lining_polyline(current_lining_thickness)
-                    if mirror_point:
-                        lining_horizontal_polyline = builder.mirror(
-                            lining_horizontal_polyline,
-                            mirror_axes=V(1, 0),
-                            mirror_point=mirror_point
-                        )
-                        builder.translate(lining_horizontal_polyline, -mirror_point)
-                    lining_horizontal_extruded = builder.extrude(
-                        lining_horizontal_polyline,
-                        magnitude=panel_width - (thickness[0] + thickness[2]),
-                        extrusion_vector=V(0, 0, -1),
-                        position_z_axis=V(-1, 0, 0),
-                        position_x_axis=V(0, 0, 1),
-                    )
-                    return lining_horizontal_extruded
-
-                lining_horizontal_bottom = create_horizontal_lining(thickness[3])
-                builder.translate(lining_horizontal_bottom, V(thickness[0], 0, 0))
-
-                lining_horizontal_top = create_horizontal_lining(thickness[1], mirror_point=V(thickness[1], 0))
-                builder.translate(lining_horizontal_top, V(thickness[0], 0, panel_height - thickness[1]))
-
-                # TODO: should implement mirror by Z for more readability
-                # TODO: investigate meaning of mirror axes in case of custom x/y/z space
-                # lining_horizontal_mirrored = builder.mirror(
-                #     lining_horizontal_extruded,
-                #     mirror_point=V(0, panel_height/2),
-                #     mirror_axes=V(0,1),
-                #     create_copy=True
-                # )
-
-                lining_items.extend([lining_horizontal_bottom, lining_horizontal_top])
-                current_items.extend(lining_items)
-
-                # PANEL
-                panel_items = []
-
-                panel_position = V(
-                    lining_panel_offset_x, (lining_depth - panel_depth) + lining_panel_offset_y, lining_panel_offset_x
-                )
-                panel_rect = builder.rectangle(size=V(panel_actual_width, 0, panel_actual_height))
-                glass_rect = builder.rectangle(
-                    size=V(glass_width, 0, glass_height), position=V(panel_thickness, 0, panel_thickness)
-                )
-                panel_profile = builder.profile(panel_rect, inner_curves=glass_rect)
-                panel_extruded = builder.extrude(
-                    panel_profile, panel_depth, extrusion_vector=V(0, 1, 0), position=panel_position
-                )
-                panel_items.append(panel_extruded)
-
-                current_items.extend(panel_items)
-
-                # add glass
-                glass_position = panel_position + V(0, panel_depth / 2 - glass_thickness / 2, 0)
-                glass_rect = builder.deep_copy(glass_rect)
-                glass = builder.extrude(
-                    glass_rect, glass_thickness, extrusion_vector=V(0, 1, 0), position=glass_position
-                )
-                current_items.append(glass)
-
-                # translate panel
-                accumulated_offset = V(accumulated_width, 0, accumulated_height[column_i])
-                builder.translate(current_items, accumulated_offset)
-
                built_panels.append(panel_i)
-                window_items.extend(current_items)
+                window_items.extend(chain(*current_window_items))

-                accumulated_height[column_i] += panel_height
-                accumulated_width += panel_width
+                accumulated_height[column_i] += lining_height
+                accumulated_width += lining_width

        builder.translate(window_items, V(0, lining_offset, 0))  # wall offset
        representation = builder.get_representation(self.settings["context"], window_items)