mirror of
https://github.com/IfcOpenShell/IfcOpenShell.git
synced 2026-09-16 21:42:19 +00:00
Fix various typos in src/ifcgeom* subdirs
This commit is contained in:
@@ -175,7 +175,7 @@ bool IfcGeom::Kernel::convert(const IfcSchema::IfcBooleanResult* l, TopoDS_Shape
|
|||||||
TopoDS_Shape temp;
|
TopoDS_Shape temp;
|
||||||
double d;
|
double d;
|
||||||
if (util::fit_halfspace(s1, s2, temp, d, getValue(GV_PRECISION) * 1000.)) {
|
if (util::fit_halfspace(s1, s2, temp, d, getValue(GV_PRECISION) * 1000.)) {
|
||||||
// #2665 we also set a precision-independent treshold, because in the boolean op routine
|
// #2665 we also set a precision-independent threshold, because in the boolean op routine
|
||||||
// the working fuzziness might still be increased.
|
// the working fuzziness might still be increased.
|
||||||
if (d < getValue(GV_PRECISION) * 20. || d < 0.00002) {
|
if (d < getValue(GV_PRECISION) * 20. || d < 0.00002) {
|
||||||
Logger::Message(Logger::LOG_WARNING, "Halfspace subtraction yields unchanged volume:", l);
|
Logger::Message(Logger::LOG_WARNING, "Halfspace subtraction yields unchanged volume:", l);
|
||||||
|
|||||||
@@ -169,7 +169,7 @@ bool IfcGeom::Kernel::convert(const IfcSchema::IfcCompositeCurve* l, TopoDS_Wire
|
|||||||
}
|
}
|
||||||
|
|
||||||
if (converted_segments.Extent() == 0) {
|
if (converted_segments.Extent() == 0) {
|
||||||
Logger::Message(Logger::LOG_ERROR, "No segment succesfully converted:", l);
|
Logger::Message(Logger::LOG_ERROR, "No segment successfully converted:", l);
|
||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -62,7 +62,7 @@ bool IfcGeom::Kernel::convert(const IfcSchema::IfcCurveBoundedPlane* l, TopoDS_S
|
|||||||
ShapeFix_Shape sfs(mf.Face());
|
ShapeFix_Shape sfs(mf.Face());
|
||||||
sfs.Perform();
|
sfs.Perform();
|
||||||
|
|
||||||
// `trsf` consitutes the placement of the plane and therefore has unit scale factor
|
// `trsf` constitutes the placement of the plane and therefore has unit scale factor
|
||||||
face = TopoDS::Face(sfs.Shape()).Moved(trsf);
|
face = TopoDS::Face(sfs.Shape()).Moved(trsf);
|
||||||
|
|
||||||
return true;
|
return true;
|
||||||
|
|||||||
@@ -56,7 +56,7 @@ bool IfcGeom::Kernel::convert(const IfcSchema::IfcFace* l, TopoDS_Shape& result)
|
|||||||
TopoDS_Shape surface_shape;
|
TopoDS_Shape surface_shape;
|
||||||
if (!convert_shape(fs->FaceSurface(), surface_shape)) return false;
|
if (!convert_shape(fs->FaceSurface(), surface_shape)) return false;
|
||||||
|
|
||||||
// FIXME: Assert this obtaines the only face
|
// FIXME: Assert this obtains the only face
|
||||||
TopExp_Explorer exp(surface_shape, TopAbs_FACE);
|
TopExp_Explorer exp(surface_shape, TopAbs_FACE);
|
||||||
if (!exp.More()) return false;
|
if (!exp.More()) return false;
|
||||||
|
|
||||||
|
|||||||
@@ -1239,7 +1239,7 @@ bool IfcGeom::Kernel::fold_layers(const IfcSchema::IfcWall* wall, const IfcRepre
|
|||||||
typedef std::vector< std::vector<Handle_Geom_Surface> > result_t;
|
typedef std::vector< std::vector<Handle_Geom_Surface> > result_t;
|
||||||
endpoint_connections_t endpoint_connections;
|
endpoint_connections_t endpoint_connections;
|
||||||
|
|
||||||
// Find the semantic connections ot other wall elements when they are not connected 'AT_PATH' because
|
// Find the semantic connections to other wall elements when they are not connected 'AT_PATH' because
|
||||||
// in that latter case no folds need to be made.
|
// in that latter case no folds need to be made.
|
||||||
for (IfcSchema::IfcRelConnectsPathElements::list::it it = connections->begin(); it != connections->end(); ++it) {
|
for (IfcSchema::IfcRelConnectsPathElements::list::it it = connections->begin(); it != connections->end(); ++it) {
|
||||||
IfcSchema::IfcRelConnectsPathElements* connection = *it;
|
IfcSchema::IfcRelConnectsPathElements* connection = *it;
|
||||||
@@ -1360,7 +1360,7 @@ bool IfcGeom::Kernel::fold_layers(const IfcSchema::IfcWall* wall, const IfcRepre
|
|||||||
// range. It's only a safeguard though, so can probably be approximated.
|
// range. It's only a safeguard though, so can probably be approximated.
|
||||||
const double axis_length = own_axis_start.Distance(own_axis_end);
|
const double axis_length = own_axis_start.Distance(own_axis_end);
|
||||||
if (length_required > axis_length) {
|
if (length_required > axis_length) {
|
||||||
Logger::Warning("The wall axis is not long enough to accomodate the fold points");
|
Logger::Warning("The wall axis is not long enough to accommodate the fold points");
|
||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -1455,7 +1455,7 @@ bool IfcGeom::Kernel::fold_layers(const IfcSchema::IfcWall* wall, const IfcRepre
|
|||||||
result_t::iterator result_vector = result.begin() + 1;
|
result_t::iterator result_vector = result.begin() + 1;
|
||||||
|
|
||||||
// nb The first layer is never folded, because it corresponds
|
// nb The first layer is never folded, because it corresponds
|
||||||
// to one of the longitudonal faces of the wall. Hence the +1
|
// to one of the longitudinal faces of the wall. Hence the +1
|
||||||
for (surfaces_t::const_iterator jt = surfaces.begin() + 1; jt != surfaces.end() - 1; ++jt, ++result_vector) {
|
for (surfaces_t::const_iterator jt = surfaces.begin() + 1; jt != surfaces.end() - 1; ++jt, ++result_vector) {
|
||||||
layer_offset += *thickness++;
|
layer_offset += *thickness++;
|
||||||
|
|
||||||
|
|||||||
@@ -700,7 +700,7 @@ namespace IfcGeom {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// Check if this represenation has (or will be) processed as part its mapped representation
|
// Check if this representation has (or will be) processed as part its mapped representation
|
||||||
bool representation_processed_as_mapped_item = false;
|
bool representation_processed_as_mapped_item = false;
|
||||||
IfcSchema::IfcRepresentation* representation_mapped_to = kernel.representation_mapped_to(representation);
|
IfcSchema::IfcRepresentation* representation_mapped_to = kernel.representation_mapped_to(representation);
|
||||||
if (representation_mapped_to) {
|
if (representation_mapped_to) {
|
||||||
|
|||||||
@@ -172,7 +172,7 @@ bool IfcGeom::Kernel::convert(const IfcSchema::IfcTrimmedCurve* l, TopoDS_Wire&
|
|||||||
// Fix from @sanderboer to compare using model tolerance, see #744
|
// Fix from @sanderboer to compare using model tolerance, see #744
|
||||||
// Made dependent on radius, see #928
|
// Made dependent on radius, see #928
|
||||||
|
|
||||||
// A good critereon for determining whether to take full curve
|
// A good criterion for determining whether to take full curve
|
||||||
// or trimmed segment would be whether there are other curve segments or this
|
// or trimmed segment would be whether there are other curve segments or this
|
||||||
// is the only one.
|
// is the only one.
|
||||||
boost::optional<size_t> num_segments;
|
boost::optional<size_t> num_segments;
|
||||||
@@ -227,7 +227,7 @@ bool IfcGeom::Kernel::convert(const IfcSchema::IfcTrimmedCurve* l, TopoDS_Wire&
|
|||||||
TopoDS_Vertex v0, v1;
|
TopoDS_Vertex v0, v1;
|
||||||
TopExp::Vertices(e, v0, v1);
|
TopExp::Vertices(e, v0, v1);
|
||||||
e = TopoDS::Edge(BRepBuilderAPI_MakeEdge(v0, v1).Edge().Oriented(e.Orientation()));
|
e = TopoDS::Edge(BRepBuilderAPI_MakeEdge(v0, v1).Edge().Oriented(e.Orientation()));
|
||||||
Logger::Warning("Subsituted edge with linear approximation", l);
|
Logger::Warning("Substituted edge with linear approximation", l);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -72,7 +72,7 @@ IfcGeom::Kernel::faceset_helper<CP, LP>::faceset_helper(
|
|||||||
// double bdiff = std::sqrt(box.SquareExtent());
|
// double bdiff = std::sqrt(box.SquareExtent());
|
||||||
|
|
||||||
// @todo the bounding box diagonal is not used (see above)
|
// @todo the bounding box diagonal is not used (see above)
|
||||||
// because we're explicitly interested in the miminal
|
// because we're explicitly interested in the minimal
|
||||||
// dimension of the element to limit the tolerance (for sheet-
|
// dimension of the element to limit the tolerance (for sheet-
|
||||||
// like elements for example). But the way below is very
|
// like elements for example). But the way below is very
|
||||||
// dependent on orientation due to the usage of the
|
// dependent on orientation due to the usage of the
|
||||||
|
|||||||
@@ -589,7 +589,7 @@ bool IfcGeom::util::create_solid_from_faces(const TopTools_ListOfShape& face_lis
|
|||||||
bool has_shared_edges = false;
|
bool has_shared_edges = false;
|
||||||
TopTools_MapOfShape edge_set;
|
TopTools_MapOfShape edge_set;
|
||||||
|
|
||||||
// In case there are wire interesections or failures in non-planar wire triangulations
|
// In case there are wire intersections or failures in non-planar wire triangulations
|
||||||
// the idea is to let occt do an exhaustive search of edge partners. But we have not
|
// the idea is to let occt do an exhaustive search of edge partners. But we have not
|
||||||
// found a case where this actually improves boolean ops later on.
|
// found a case where this actually improves boolean ops later on.
|
||||||
// if (!faceset_helper_ || !faceset_helper_->non_manifold()) {
|
// if (!faceset_helper_ || !faceset_helper_->non_manifold()) {
|
||||||
|
|||||||
@@ -1183,9 +1183,9 @@ bool IfcGeom::util::boolean_operation(const boolean_settings& settings, const To
|
|||||||
}
|
}
|
||||||
|
|
||||||
if (!success) {
|
if (!success) {
|
||||||
PERF("boolean operation: manifoldness check excemption");
|
PERF("boolean operation: manifoldness check exemption");
|
||||||
|
|
||||||
// An excemption for the requirement to be manifold: When the cut operands have overlapping edge belonging to faces that do not overlap.
|
// An exemption for the requirement to be manifold: When the cut operands have overlapping edge belonging to faces that do not overlap.
|
||||||
bool operands_nonmanifold = false;
|
bool operands_nonmanifold = false;
|
||||||
if (op == BOPAlgo_CUT) {
|
if (op == BOPAlgo_CUT) {
|
||||||
TopTools_IndexedMapOfShape edges;
|
TopTools_IndexedMapOfShape edges;
|
||||||
@@ -1248,7 +1248,7 @@ bool IfcGeom::util::boolean_operation(const boolean_settings& settings, const To
|
|||||||
bool has_open_shells = false;
|
bool has_open_shells = false;
|
||||||
|
|
||||||
if (op == BOPAlgo_CUT) {
|
if (op == BOPAlgo_CUT) {
|
||||||
PERF("boolean operation: open shell face adition check");
|
PERF("boolean operation: open shell face addition check");
|
||||||
|
|
||||||
for (TopExp_Explorer exp(a, TopAbs_SHELL); exp.More(); exp.Next()) {
|
for (TopExp_Explorer exp(a, TopAbs_SHELL); exp.More(); exp.Next()) {
|
||||||
if (!exp.Current().Closed()) {
|
if (!exp.Current().Closed()) {
|
||||||
|
|||||||
Reference in New Issue
Block a user