Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-20 06:58:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

remove_deep2 optimization for cases when the same entity is referenced by multiple other in the subgraph #6784

Browse Source
This commit is contained in:
Andrej
2025-06-10 18:06:59 +05:00
parent 1fecd77121
commit b4bc7ec371
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcopenshell-python/ifcopenshell/util/element.py
+9 -1
View File
@@ -1597,10 +1597,17 @@ def remove_deep2(
subgraph.extend(also_consider) subgraph.extend(also_consider)
subgraph_set = set(subgraph) subgraph_set = set(subgraph)
subelement_queue = [element] subelement_queue = [element]
# Cache already processed entities to avoid traversing them multiple time.
# E.g. lots of IFCINDEXEDPOLYCURVES may reference the same IFCCARTESIANPOINTLIST2D.
processed_ids: set[int] = set()
while subelement_queue: while subelement_queue:
subelement = subelement_queue.pop(0) subelement = subelement_queue.pop(0)
subelement_id = subelement.id()
if ( if (
subelement.id() subelement_id
and subelement_id not in processed_ids
and subelement not in do_not_delete and subelement not in do_not_delete
and ( and (
# 0 or 1 inverses guarantees that the subelement only exists in this subgraph # 0 or 1 inverses guarantees that the subelement only exists in this subgraph
@@ -1623,6 +1630,7 @@ def remove_deep2(
for i, attribute in enumerate(subelement): for i, attribute in enumerate(subelement):
if isinstance(attribute, tuple) and len(attribute) > 10: if isinstance(attribute, tuple) and len(attribute) > 10:
subelement[i] = [] subelement[i] = []
processed_ids.add(subelement_id)
if ifc_file.to_delete is not None: if ifc_file.to_delete is not None:
ifc_file.to_delete.update(to_delete) ifc_file.to_delete.update(to_delete)