Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-20 06:58:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix test_number_formatting tests and add cases (#7332)

Browse Source
This commit is contained in:
Esteban Dugueperoux
2025-11-11 18:25:00 +01:00
committed by GitHub
parent 25d3edc537
commit b8adddc648
2 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcopenshell-python/ifcopenshell/util/selector.py
+2 -1
View File
@@ -259,6 +259,7 @@ class FormatTransformer(lark.Transformer):
) )
def imperial_length(self, args): def imperial_length(self, args):
args = list(filter(lambda x: x is not None, args))
if len(args) == 2: if len(args) == 2:
input_unit, output_unit = "foot", "foot" input_unit, output_unit = "foot", "foot"
value, precision = args value, precision = args
@@ -279,7 +280,7 @@ class FormatTransformer(lark.Transformer):
return ifcopenshell.util.unit.format_length( return ifcopenshell.util.unit.format_length(
float(value), float(value),
int(precision), int(precision),
suppress_zero_inches=suppress_zero_inches, suppress_zero_inches=(suppress_zero_inches if suppress_zero_inches is not None else False),
unit_system="imperial", unit_system="imperial",
input_unit=input_unit, input_unit=input_unit,
output_unit=output_unit, output_unit=output_unit,
src/ifcopenshell-python/test/util/test_selector.py
+4
View File
@@ -73,6 +73,10 @@ class TestFormat:
assert subject.format('imperial_length("3.123", 2)') == "3' - 1 1/2\"" assert subject.format('imperial_length("3.123", 2)') == "3' - 1 1/2\""
assert subject.format('imperial_length("123.123", 2, "inch", "foot")') == "10' - 3\"" assert subject.format('imperial_length("123.123", 2, "inch", "foot")') == "10' - 3\""
assert subject.format('imperial_length("123.123", 2, "inch", "inch")') == '123"' assert subject.format('imperial_length("123.123", 2, "inch", "inch")') == '123"'
assert subject.format('imperial_length(3.0, 4, "foot", "foot", true)') == "3'"
assert subject.format('imperial_length(3.0, 4, "foot", "foot", True)') == "3'"
assert subject.format('imperial_length(3.0, 4, "foot", "foot", false)') == "3' - 0\""
assert subject.format('imperial_length(3.0, 4, "foot", "foot", False)') == "3' - 0\""
class TestGetElementValue(test.bootstrap.IFC4): class TestGetElementValue(test.bootstrap.IFC4):