From c23972d440a1675145bf18696e16a7492a9218a2 Mon Sep 17 00:00:00 2001 From: Andrej730 Date: Wed, 2 Sep 2026 17:59:56 +0500 Subject: [PATCH] test_brick: fix warnings from `sqlalchemy` When fixing warnings, noticed that was working a bit inproperly - `bnode` always end up being an empty list (because there's no `brick, A, REF.IFCReference` triple), so then passing empty list to `triples` resulted in selecting all nodes isntead of just the expected `bnode` (that's the behaviour `sqlachemy` was sending the warnings about - when empty lists unexpectedly selected everything). --- src/bonsai/test/tool/test_brick.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/bonsai/test/tool/test_brick.py b/src/bonsai/test/tool/test_brick.py index c3d1f429e3..325bb7a616 100644 --- a/src/bonsai/test/tool/test_brick.py +++ b/src/bonsai/test/tool/test_brick.py @@ -148,10 +148,10 @@ class TestAddBrickifcReference(NewFile): project = URIRef(f"http://example.org/digitaltwin#{tool.Ifc.get().by_type('IfcProject')[0].GlobalId}") subject.add_brickifc_reference("http://example.org/digitaltwin#foo", element, project) brick = URIRef("http://example.org/digitaltwin#foo") - bnode = list(BrickStore.graph.triples((brick, A, REF.IFCReference))) - assert list(BrickStore.graph.triples((bnode, REF.hasIfcProjectReference, URIRef(project)))) - assert list(BrickStore.graph.triples((bnode, REF.ifcGlobalID, Literal(element.GlobalId)))) - assert list(BrickStore.graph.triples((bnode, REF.ifcName, Literal(element.Name)))) + bnode = next(BrickStore.graph.triples((brick, REF.hasExternalReference, None)))[2] + assert len(list(BrickStore.graph.triples((bnode, REF.hasIfcProjectReference, URIRef(project))))) == 1 + assert len(list(BrickStore.graph.triples((bnode, REF.ifcGlobalID, Literal(element.GlobalId))))) == 1 + assert len(list(BrickStore.graph.triples((bnode, REF.ifcName, Literal(element.Name))))) == 1 class TestAddRelation(NewFile):