From c7268b6f424520d75245562fb333bd0dec63ce44 Mon Sep 17 00:00:00 2001
From: Dion Moult <dion@thinkmoult.com>
Date: Fri, 24 Nov 2023 14:44:28 +1100
Subject: [PATCH] Fix #4037. IfcTester reports now also include an element type
 column.

---
 src/ifctester/ifctester/reporter.py | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/ifctester/ifctester/reporter.py b/src/ifctester/ifctester/reporter.py
index 8e2b183fb1..83effbfd87 100644
--- a/src/ifctester/ifctester/reporter.py
+++ b/src/ifctester/ifctester/reporter.py
@@ -382,6 +382,7 @@ class Ods(Json):
                 "GlobalId",
                 "Tag",
                 "Element",
+                "ElementType",
             ]:
                 tc = TableCell(valuetype="string", stylename="h")
                 tc.addElement(P(text=header))
@@ -391,6 +392,8 @@ class Ods(Json):
                 if requirement["status"]:
                     continue
                 for failure in requirement["failed_entities"]:
+                    element = failure.get("element", None)
+                    element_type = ifcopenshell.util.element.get_type(failure.get("element", None))
                     row = [
                         requirement["description"],
                         failure.get("reason", "No reason provided"),
@@ -400,7 +403,8 @@ class Ods(Json):
                         failure["description"],
                         failure["global_id"],
                         failure["tag"],
-                        str(failure.get("element", "No element found")),
+                        str(element) if element else "N/A",
+                        str(element_type) if element_type else "N/A",
                     ]
                     tr = TableRow()
                     c = 0