From c73fedaaaf832e6d044fa23344ffc8b342a1a7a9 Mon Sep 17 00:00:00 2001 From: Vukas Pajic <83825269+vulevukusej@users.noreply.github.com> Date: Fri, 1 Jul 2022 13:41:20 +0200 Subject: [PATCH] fix error that stopped user from adding properties --- .../ifcopenshell/api/pset/edit_pset.py | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/src/ifcopenshell-python/ifcopenshell/api/pset/edit_pset.py b/src/ifcopenshell-python/ifcopenshell/api/pset/edit_pset.py index d6b234071d..28c307756c 100644 --- a/src/ifcopenshell-python/ifcopenshell/api/pset/edit_pset.py +++ b/src/ifcopenshell-python/ifcopenshell/api/pset/edit_pset.py @@ -102,9 +102,11 @@ class Usecase: if value is None: continue if isinstance(value, ifcopenshell.entity_instance): - nominal_value = value if value.is_a(True) == "IFC4.IfcPropertyEnumeratedValue": properties.append(value) + continue + else: + nominal_value = value #TODO-The following "elif" is temporary code, will need to refactor at some point - vulevukusej elif isinstance(value, list): for pset_template in self.settings["pset_template"].HasPropertyTemplates: @@ -122,17 +124,18 @@ class Usecase: EnumerationReference=prop_enum ) properties.append(prop_enum_value) + continue else: primary_measure_type = self.get_primary_measure_type(name, new_value=value) value = self.cast_value_to_primary_measure_type(value, primary_measure_type) nominal_value = self.file.create_entity(primary_measure_type, value) - properties.append( - self.file.create_entity( - "IfcPropertySingleValue", - **{"Name": name, "NominalValue": nominal_value}, - ) + properties.append( + self.file.create_entity( + "IfcPropertySingleValue", + **{"Name": name, "NominalValue": nominal_value}, ) + ) return properties def extend_pset_with_new_properties(self, new_properties):